Add option to disallow the discarding of a tab that was previously discarded.

chrome/browser/memory/oom_priority_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/memory/memory_pressure_listener.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/memory/oom_priority_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
+#include "chrome/browser/ui/tabs/tab_discard_state.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/test/test_utils.h"
 #include "url/gurl.h"
 
 using content::OpenURLParams;
@@ skipping 65 matching lines @@
       content::NotificationService::AllSources());
   OpenURLParams open5(GURL("chrome://dns"), content::Referrer(), CURRENT_TAB,
                       ui::PAGE_TRANSITION_TYPED, false);
   browser()->OpenURL(open5);
   load5.Wait();
 
   EXPECT_EQ(3, browser()->tab_strip_model()->count());
 
   // Discard a tab.  It should kill the first tab, since it was the oldest
   // and was not selected.
+  auto tsm = browser()->tab_strip_model();
   EXPECT_TRUE(oom_priority_manager->DiscardTab());
-  EXPECT_EQ(3, browser()->tab_strip_model()->count());
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
-  EXPECT_TRUE(oom_priority_manager->recent_tab_discard());
+  EXPECT_EQ(3, tsm->count());
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(0)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Run discard again, make sure it kills the second tab.
   EXPECT_TRUE(oom_priority_manager->DiscardTab());
-  EXPECT_EQ(3, browser()->tab_strip_model()->count());
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
+  EXPECT_EQ(3, tsm->count());
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(0)));
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Kill the third tab. It should not kill the last tab, since it is active
   // tab.
   EXPECT_FALSE(oom_priority_manager->DiscardTab());
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(0));
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(0)));
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Kill the third tab after making second tab active.
-  browser()->tab_strip_model()->ActivateTabAt(1, true);
-  EXPECT_EQ(1, browser()->tab_strip_model()->active_index());
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  browser()->tab_strip_model()->DiscardWebContentsAt(2);
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(2));
+  tsm->ActivateTabAt(1, true);
+  EXPECT_EQ(1, tsm->active_index());
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  tsm->DiscardWebContentsAt(2);
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Force creation of the FindBarController.
   browser()->GetFindBarController();
 
   // Select the first tab.  It should reload.
   WindowedNotificationObserver reload1(
       content::NOTIFICATION_NAV_ENTRY_COMMITTED,
       content::NotificationService::AllSources());
   chrome::SelectNumberedTab(browser(), 0);
   reload1.Wait();
   // Make sure the FindBarController gets the right WebContents.
   EXPECT_EQ(browser()->GetFindBarController()->web_contents(),
-            browser()->tab_strip_model()->GetActiveWebContents());
-  EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(0));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  EXPECT_TRUE(browser()->tab_strip_model()->IsTabDiscarded(2));
+            tsm->GetActiveWebContents());
+  EXPECT_EQ(0, tsm->active_index());
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(0)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  EXPECT_TRUE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Select the third tab. It should reload.
   WindowedNotificationObserver reload2(
       content::NOTIFICATION_NAV_ENTRY_COMMITTED,
       content::NotificationService::AllSources());
   chrome::SelectNumberedTab(browser(), 2);
   reload2.Wait();
-  EXPECT_EQ(2, browser()->tab_strip_model()->active_index());
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(0));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(1));
-  EXPECT_FALSE(browser()->tab_strip_model()->IsTabDiscarded(2));
+  EXPECT_EQ(2, tsm->active_index());
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(0)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(1)));
+  EXPECT_FALSE(TabDiscardState::IsDiscarded(tsm->GetWebContentsAt(2)));
 
   // Navigate the third tab back twice.  We used to crash here due to
   // crbug.com/121373.
   EXPECT_TRUE(chrome::CanGoBack(browser()));
   EXPECT_FALSE(chrome::CanGoForward(browser()));
   WindowedNotificationObserver back1(
       content::NOTIFICATION_NAV_ENTRY_COMMITTED,
       content::NotificationService::AllSources());
   chrome::GoBack(browser(), CURRENT_TAB);
   back1.Wait();
@@ skipping 53 matching lines @@
     if (oom_priority_manager->recent_tab_discard())
       break;
   }
   EXPECT_TRUE(oom_priority_manager->recent_tab_discard());
 }
 
 }  // namespace
 }  // namespace memory
 
 #endif  // OS_WIN || OS_CHROMEOS