Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1331973002: Remove clang type profiler and deep memory profiler. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, jam, Dai Mikurube (NOT FULLTIME), darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove clang type profiler and deep memory profiler. Looks like it's no longer functional and unused. BUG=490464 TBR=jochen Committed: https://crrev.com/5747a19cad8feb463125f3c80376d3c535f25523 Cr-Commit-Position: refs/heads/master@{#348392}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2621 lines) Patch
M base/BUILD.gn View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M base/allocator/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M base/allocator/allocator.gyp View 4 chunks +0 lines, -114 lines 0 comments Download
D base/allocator/type_profiler.h View 1 chunk +0 lines, -40 lines 0 comments Download
D base/allocator/type_profiler.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D base/allocator/type_profiler_control.h View 1 chunk +0 lines, -31 lines 0 comments Download
D base/allocator/type_profiler_control.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D base/allocator/type_profiler_map_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D base/allocator/type_profiler_tcmalloc.h View 1 chunk +0 lines, -29 lines 0 comments Download
D base/allocator/type_profiler_tcmalloc.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D base/allocator/type_profiler_unittest.cc View 1 chunk +0 lines, -189 lines 0 comments Download
M base/base.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M base/process/launch_posix.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M build/common.gypi View 4 chunks +0 lines, -36 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
D build/toolchain/clang.gni View 1 chunk +0 lines, -9 lines 0 comments Download
M build/toolchain/cros/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/toolchain/linux/BUILD.gn View 3 chunks +4 lines, -15 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/app/content_main_runner.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D third_party/tcmalloc/chromium/src/deep-heap-profile.h View 1 chunk +0 lines, -407 lines 0 comments Download
D third_party/tcmalloc/chromium/src/deep-heap-profile.cc View 1 chunk +0 lines, -1161 lines 0 comments Download
D third_party/tcmalloc/chromium/src/gperftools/type_profiler_map.h View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profile-table.h View 4 chunks +0 lines, -32 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profile-table.cc View 3 chunks +0 lines, -61 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profiler.cc View 7 chunks +3 lines, -80 lines 0 comments Download
D third_party/tcmalloc/chromium/src/type_profiler_map.cc View 1 chunk +0 lines, -112 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Nico
5 years, 3 months ago (2015-09-10 23:03:13 UTC) #2
haraken
Yes, DMP hasn't been maintained for a long time. It was replaced with memory-infra. LGTM ...
5 years, 3 months ago (2015-09-10 23:25:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331973002/40001
5 years, 3 months ago (2015-09-11 07:24:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/98578)
5 years, 3 months ago (2015-09-11 07:33:46 UTC) #7
Nico
Jochen: content owners plz
5 years, 3 months ago (2015-09-11 08:04:10 UTC) #9
Nico
On 2015/09/11 08:04:10, Nico (afk Tue-Wed Sep 7-8) wrote: > Jochen: content owners plz Tbring
5 years, 3 months ago (2015-09-11 13:45:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331973002/40001
5 years, 3 months ago (2015-09-11 13:46:26 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-11 13:51:06 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5747a19cad8feb463125f3c80376d3c535f25523 Cr-Commit-Position: refs/heads/master@{#348392}
5 years, 3 months ago (2015-09-11 13:51:59 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:22:10 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5747a19cad8feb463125f3c80376d3c535f25523
Cr-Commit-Position: refs/heads/master@{#348392}

Powered by Google App Engine
This is Rietveld 408576698