Issue 133193006: Revert "Dispose Isolate at end of cctest."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133193006: Revert "Dispose Isolate at end of cctest." (Closed)

Created:
6 years, 10 months ago by Sven Panne

Modified:
6 years, 10 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Dispose Isolate at end of cctest." Things work locally, only the waterfall is unhappy for some arcane reason. Investigating... TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19049

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	test/cctest/cctest.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Sven Panne

6 years, 10 months ago (2014-02-04 09:41:27 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r19049 (tree was closed).