Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1331913004: Add ozone_unittests to the build. (Closed)

Created:
5 years, 3 months ago by cdotstout
Modified:
5 years, 3 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
cdotstout
5 years, 3 months ago (2015-09-10 22:38:52 UTC) #2
jamesr
Do you want these to run on the bots and on developer's machines (if they ...
5 years, 3 months ago (2015-09-10 22:58:44 UTC) #3
cdotstout
On 2015/09/10 22:58:44, jamesr wrote: > Do you want these to run on the bots ...
5 years, 3 months ago (2015-09-10 23:16:32 UTC) #4
jamesr
OK. In the meantime could you drop a README somewhere describing how to run these ...
5 years, 3 months ago (2015-09-10 23:19:27 UTC) #5
cdotstout
On 2015/09/10 23:19:27, jamesr wrote: > OK. In the meantime could you drop a README ...
5 years, 3 months ago (2015-09-10 23:26:14 UTC) #6
cdotstout
Committed patchset #2 (id:20001) manually as cd8f5c1c06c2356b76d32cd555b654119babe785 (presubmit successful).
5 years, 3 months ago (2015-09-10 23:29:56 UTC) #7
cdotstout
5 years, 3 months ago (2015-09-11 00:57:41 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1331913004/diff/1/ui/ozone/platform/drm/BUILD.gn
File ui/ozone/platform/drm/BUILD.gn (right):

https://codereview.chromium.org/1331913004/diff/1/ui/ozone/platform/drm/BUILD...
ui/ozone/platform/drm/BUILD.gn:179: "//ui/ozone:ozone",
On 2015/09/10 22:58:44, jamesr wrote:
> just "//ui/ozone"

Done.

Powered by Google App Engine
This is Rietveld 408576698