Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1331833002: Revert of Oilpan: fix build after r201994. (Closed)

Created:
5 years, 3 months ago by Mike West
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: fix build after r201994. (patchset #1 id:1 of https://codereview.chromium.org/1327193002/ ) Reason for revert: The patch which this patch patched caused leaks on WebKit Linux Leaks (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/14049). Reverting this patch so I can revert the other one. Original issue's description: > Oilpan: fix build after r201994. > > TBR=oilpan-reviews > BUG=488628 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202004 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488628 Committed: https://crrev.com/75497d81015f8a0ea597fa04a13e6d9eba8f56bd git-svn-id: svn://svn.chromium.org/blink/trunk@202041 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/editing/InputMethodController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Created Revert of Oilpan: fix build after r201994.
5 years, 3 months ago (2015-09-10 09:00:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331833002/1
5 years, 3 months ago (2015-09-10 09:00:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202041
5 years, 3 months ago (2015-09-10 09:00:55 UTC) #3
haraken
LGTM
5 years, 3 months ago (2015-09-10 09:02:42 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:08:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75497d81015f8a0ea597fa04a13e6d9eba8f56bd

Powered by Google App Engine
This is Rietveld 408576698