Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1331803003: [es6] fixup for rest parameters perf test (Closed)

Created:
5 years, 3 months ago by caitp (gmail)
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] fixup for rest parameters perf test BUG=v8:2160 LOG=N NOTRY=true R=adamk, machenbach@chromium.org, rossberg Committed: https://crrev.com/0cc8eaa4c628543b520ab48667176967a225f7db Cr-Commit-Position: refs/heads/master@{#30682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/js-perf-test/JSTests.json View 1 chunk +1 line, -1 line 0 comments Download
M test/js-perf-test/RestParameters/rest.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
Quick fix for the error in JSTests.json
5 years, 3 months ago (2015-09-10 12:31:21 UTC) #2
Michael Achenbach
lgtm
5 years, 3 months ago (2015-09-10 13:43:15 UTC) #3
Michael Achenbach
Thanks!
5 years, 3 months ago (2015-09-10 13:43:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331803003/1
5 years, 3 months ago (2015-09-10 13:43:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 13:45:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0cc8eaa4c628543b520ab48667176967a225f7db Cr-Commit-Position: refs/heads/master@{#30682}
5 years, 3 months ago (2015-09-10 13:45:15 UTC) #8
Michael Achenbach
5 years, 3 months ago (2015-09-10 14:10:23 UTC) #9
Message was sent while issue was closed.
This resolved the issue. The data is now tracked.

Powered by Google App Engine
This is Rietveld 408576698