Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 133173004: Revert of Revert of Enable OrientationEvent only for android. (Closed)

Created:
6 years, 11 months ago by maheshkk
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Revert of Enable OrientationEvent only for android. (https://codereview.chromium.org/130053005/) Reason for revert: Fixed the original issue and tested content_shell to load and pass orientation test case. https://codereview.chromium.org/141303002/. Original issue's description: > Revert of Enable OrientationEvent only for android. (https://codereview.chromium.org/131913003/) > > Reason for revert: > Causes crashes on Android on loading a web page, more details in https://code.google.com/p/chromium/issues/detail?id=335258 > > Original issue's description: > > Enable OrientationEvent only for android. > > > > BUG=181136, 331337 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245210 > > TBR=darin@chromium.org,mahesh.kk@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=181136, 331337 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245310 TBR=darin@chromium.org,thakis@chromium.org,estade@chromium.org,mariakhomenko@chromium.org NOTREECHECKS=true NOTRY=true BUG=181136, 331337 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
maheshkk
Created Revert of Revert of Enable OrientationEvent only for android.
6 years, 11 months ago (2014-01-17 17:32:05 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-17 17:32:24 UTC) #2
maheshkk
On 2014/01/17 17:32:05, maheshkk wrote: > Created Revert of Revert of Enable OrientationEvent only for ...
6 years, 11 months ago (2014-01-17 17:32:58 UTC) #3
Nico
On 2014/01/17 17:32:58, maheshkk wrote: > On 2014/01/17 17:32:05, maheshkk wrote: > > Created Revert ...
6 years, 11 months ago (2014-01-17 17:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/133173004/1
6 years, 11 months ago (2014-01-17 17:35:45 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 17:36:07 UTC) #6
Message was sent while issue was closed.
Change committed as 245545

Powered by Google App Engine
This is Rietveld 408576698