Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1331673002: ipc: Convert k(u)int*max types from basictypes.h to std::numeric_limits variants. (Closed)

Created:
5 years, 3 months ago by tfarina
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, viettrungluu, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Convert k(u)int*max types from basictypes.h to std::numeric_limits variants. As the types from basictypes.h are deprecated this moves them to std::numeric_limits from <limits> or when necessary to the (U)INTx_{MIN,MAX} macros from <stdint.h>. BUG=138542 TEST=ipc_tests R=tsepez@chromium.org Committed: https://crrev.com/7023f52b1ae1a47e3764cf5e7ad8ce65c73c0e54 Cr-Commit-Position: refs/heads/master@{#348474}

Patch Set 1 #

Patch Set 2 : fix win? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ipc/ipc_channel.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_message.h View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
tfarina
Next I will convert basictypes.h includes to macros.h. PTAL.
5 years, 3 months ago (2015-09-09 18:03:27 UTC) #1
tfarina
Ping? Copying Carlos, just in case.
5 years, 3 months ago (2015-09-10 18:11:28 UTC) #2
Tom Sepez
On 2015/09/10 18:11:28, tfarina wrote: > Ping? > > Copying Carlos, just in case. I'm ...
5 years, 3 months ago (2015-09-10 18:36:24 UTC) #3
cpu_(ooo_6.6-7.5)
what Tom said
5 years, 3 months ago (2015-09-10 21:30:06 UTC) #5
tfarina
On Thursday, September 10, 2015, <tsepez@chromium.org> wrote: > On 2015/09/10 18:11:28, tfarina wrote: > >> ...
5 years, 3 months ago (2015-09-11 04:34:15 UTC) #6
Tom Sepez
> Please, don't wait for compile failures to let me know. I have no way ...
5 years, 3 months ago (2015-09-11 15:15:53 UTC) #7
tfarina
PTAL. I changed it to use the macro types from stdint.h, hopefully that will fix ...
5 years, 3 months ago (2015-09-11 17:16:44 UTC) #8
Tom Sepez
Great. LGTM.
5 years, 3 months ago (2015-09-11 17:40:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331673002/20001
5 years, 3 months ago (2015-09-11 18:31:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 19:58:58 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7023f52b1ae1a47e3764cf5e7ad8ce65c73c0e54 Cr-Commit-Position: refs/heads/master@{#348474}
5 years, 3 months ago (2015-09-11 19:59:48 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:25:51 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7023f52b1ae1a47e3764cf5e7ad8ce65c73c0e54
Cr-Commit-Position: refs/heads/master@{#348474}

Powered by Google App Engine
This is Rietveld 408576698