Issue 133163007: Use memcpy in SVGPathByteStreamSource::readType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133163007: Use memcpy in SVGPathByteStreamSource::readType (Closed)

Created:
6 years, 10 months ago by fs

Modified:
6 years, 10 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, pdr, Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use memcpy in SVGPathByteStreamSource::readType This avoids having the compiler beating around the bush trying to recognize the memcpy, and results in smaller code (roughly 50% smaller measured for GCC 4.8). All at the affordable price of upsetting a few language purists. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166516

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	Source/core/svg/SVGPathByteStreamSource.h	View		1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/133163007/1

6 years, 10 months ago (2014-02-05 17:20:48 UTC) #6

Message was sent while issue was closed.

Change committed as 166516

Expand Messages | Collapse Messages