runtime/vm/isolate.cc - Issue 1331623002: Uses SNPRINT macro where possible. Otherwise uses #define for format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 1331623002: Uses SNPRINT macro where possible. Otherwise uses #define for format. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: add missing include Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index f20e055b79ee0918bbdcdd55147a6fb781941252..0c992e107299e90b5e28aabe6b28ebb5fd0192bd 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -896,10 +896,7 @@ void Isolate::BuildName(const char* name_prefix) {

name_ = strdup(name_prefix);

return;

}

- const char* kFormat = "%s-%lld";

- intptr_t len = OS::SNPrint(NULL, 0, kFormat, name_prefix, main_port()) + 1;

- name_ = reinterpret_cast<char*>(malloc(len));

- OS::SNPrint(name_, len, kFormat, name_prefix, main_port());

+ name_ = OS::SCreate(NULL, "%s-%" Pd64 "", name_prefix, main_port());

}

« no previous file with comments | « runtime/vm/disassembler_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »