Uses SNPRINT macro where possible. Otherwise uses #define for format.

runtime/vm/assembler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/assembler.h"
 
 #include "platform/utils.h"
 #include "vm/cpu.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 163 matching lines @@
 void AssemblerBuffer::EmitObject(const Object& object) {
   // Since we are going to store the handle as part of the fixup information
   // the handle needs to be a zone handle.
   ASSERT(object.IsNotTemporaryScopedHandle());
   ASSERT(object.IsOld());
   EmitFixup(new PatchCodeWithHandle(pointer_offsets_, object));
   cursor_ += kWordSize;  // Reserve space for pointer.
 }
 
 
-// Shared macros are implemented here.

[zra, 2015/09/08 21:09:24]

These weren't used, and have a memory leak.

-void Assembler::Unimplemented(const char* message) {
-  const char* format = "Unimplemented: %s";
-  const intptr_t len = OS::SNPrint(NULL, 0, format, message);
-  char* buffer = reinterpret_cast<char*>(malloc(len + 1));
-  OS::SNPrint(buffer, len + 1, format, message);
-  Stop(buffer);
-}
-
-
-void Assembler::Untested(const char* message) {
-  const char* format = "Untested: %s";
-  const intptr_t len = OS::SNPrint(NULL, 0, format, message);
-  char* buffer = reinterpret_cast<char*>(malloc(len + 1));
-  OS::SNPrint(buffer, len + 1, format, message);
-  Stop(buffer);
-}
-
-
-void Assembler::Unreachable(const char* message) {
-  const char* format = "Unreachable: %s";
-  const intptr_t len = OS::SNPrint(NULL, 0, format, message);
-  char* buffer = reinterpret_cast<char*>(malloc(len + 1));
-  OS::SNPrint(buffer, len + 1, format, message);
-  Stop(buffer);
-}
-
-
 void Assembler::Comment(const char* format, ...) {
   if (EmittingComments()) {
     char buffer[1024];
 
     va_list args;
     va_start(args, format);
     OS::VSNPrint(buffer, sizeof(buffer), format, args);
     va_end(args);
 
     comments_.Add(new CodeComment(buffer_.GetPosition(),
@@ skipping 98 matching lines @@
       result.SetObjectAt(i, *object_pool_[i].obj_);
     } else {
       result.SetRawValueAt(i, object_pool_[i].raw_value_);
     }
   }
   return result.raw();
 }
 
 
 }  // namespace dart