Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1331603002: Use baseline code to compute message locations. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use baseline code to compute message locations. This switches Isolate::ComputeLocation to use baseline code when computing message locations. This unifies locations between optimized and non-optimized code by always going through the FrameSummary for location computation. R=bmeurer@chromium.org TEST=message/regress/regress-4266 BUG=v8:4266 LOG=n Committed: https://crrev.com/819b40aae84111592ea524fd045037463e571838 Cr-Commit-Position: refs/heads/master@{#30635}

Patch Set 1 #

Patch Set 2 : Fix illegal redeclaration. #

Patch Set 3 : Fix RobustSubStringStub. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -28 lines) Patch
M src/ast-numbering.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/scopes.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + test/message/regress/regress-4266.js View 1 chunk +5 lines, -1 line 0 comments Download
A + test/message/regress/regress-4266.out View 1 chunk +6 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-4266.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-08 13:38:46 UTC) #2
Benedikt Meurer
Awesome! LGTM
5 years, 3 months ago (2015-09-08 13:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331603002/40001
5 years, 3 months ago (2015-09-08 14:00:13 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-08 14:14:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 14:15:12 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/819b40aae84111592ea524fd045037463e571838
Cr-Commit-Position: refs/heads/master@{#30635}

Powered by Google App Engine
This is Rietveld 408576698