MD Downloads: compute card elevation via data binding

chrome/browser/resources/md_downloads/item.html

Index: chrome/browser/resources/md_downloads/item.html
diff --git a/chrome/browser/resources/md_downloads/item.html b/chrome/browser/resources/md_downloads/item.html
index 046f0407d64829470326bbd3979b41ba1c946306..7037569f95ec53df61f626acff99b65bbd44f699 100644
--- a/chrome/browser/resources/md_downloads/item.html
+++ b/chrome/browser/resources/md_downloads/item.html
@@ -17,21 +17,26 @@
       </template>
     </div>
 
-    <paper-material id="content" on-dragstart="onDragStart_">
+    <paper-material id="content" on-dragstart="onDragStart_"
+        elevation$="[[computeElevation_(isActive_)]]">
       <div id="file-icon-wrapper" class="icon-wrapper">
-        <img class="icon" id="file-icon" alt="" hidden="[[isDangerous_]]">
-        <div class="icon" id="warning" hidden="[[!isDangerous_]]"></div>
+        <img class="icon" id="file-icon" alt="" hidden$="[[isDangerous_]]">
+        <div class="icon" id="warning" hidden$="[[!isDangerous_]]"></div>
       </div>
 
       <div id="details">
-        <div id="title-area"><!-- Can't have any line breaks.
-          --><a is="action-link" id="file-link"
-              on-click="onFileLinkClick_"></a><!-- Before #name.
-          --><span id="name">[[data_.file_name]]</span>
+        <div id="title-area"><!--
+          Can't have any line breaks.

[tommycli, 2015/09/09 20:49:16]

These line breaks are okay right?

It's <span><!-- no line breaks here -->[[binding]]<!-- no line breaks here
--></span> that's not ok right?

[Dan Beam, 2015/09/09 21:00:15]

yes, <!-- \n --> is OK

[tommycli, 2015/09/09 21:03:03]

I mean, you don't need that comment to span the whitespace right?

<div id="title-area">
  <a is="action-link"...>

is okay right?

[Dan Beam, 2015/09/09 21:04:10]

no, <div id="title-area"><!--

doesn't matter what happens here!
I'm in a comment!

--><a is="action-link">

is OK

[tommycli, 2015/09/09 21:10:44]

Ah, I think we're mis-communicating.

I mean: why are those two HTML comments necessary?

[Dan Beam, 2015/09/09 21:33:03]

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
https://developer.mozilla.org/en-US/docs/Web/CSS/word-break

and btw, i don't believe <div><!-- this is ok -->[[computeThing_(param)]]<!--
because [[]] needs to be the whole textContent --></div>

+          --><a is="action-link" id="file-link" href$="[[data_.url]]"
+              on-click="onFileLinkClick_"
+              hidden$="[[!completelyOnDisk_]]">[[data_.file_name]]</a><!--
+          Before #name.
+          --><span id="name"
+              hidden$="[[completelyOnDisk_]]">[[data_.file_name]]</span>
           <span id="tag"></span>
         </div>
 
-        <a id="url" target="_blank" href="[[data_.url]]">[[data_.url]]</a>
+        <a id="url" target="_blank" href$="[[data_.url]]">[[data_.url]]</a>
 
         <div id="description"></div>