MD Downloads: compute card elevation via data binding

chrome/browser/resources/md_downloads/item.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   var Item = Polymer({
     is: 'downloads-item',
 
     /**
      * @param {!downloads.ThrottledIconLoader} iconLoader
@@ skipping 47 matching lines @@
             remove: loadTimeData.getString('controlRemoveFromList'),
             resume: loadTimeData.getString('controlResume'),
             restore: loadTimeData.getString('dangerRestore'),
             retry: loadTimeData.getString('controlRetry'),
             save: loadTimeData.getString('dangerSave'),
             show: loadTimeData.getString('controlShowInFolder'),
           };
         },
       },
 
+      isActive_: {
+        computed: 'computeIsActive_(' +
+            'data_.state, data_.file_externally_removed)',
+        type: Boolean,
+        value: true,
+      },
+
       isDangerous_: {
         computed: 'computeIsDangerous_(data_.state)',
         type: Boolean,
         value: false,
       },
 
       isInProgress_: {
         computed: 'computeIsInProgress_(data_.state)',
         type: Boolean,
         value: false,
@@ skipping 55 matching lines @@
           data.total == this.data_.total &&
           data.url == this.data_.url) {
         // TODO(dbeam): remove this once data binding is fully in place.
         return;
       }
 
       for (var key in data) {
         this.set('data_.' + key, data[key]);
       }
 
-      /** @const */ var isActive =
-          data.state != downloads.States.CANCELLED &&
-          data.state != downloads.States.INTERRUPTED &&
-          !data.file_externally_removed;
-      this.$.content.classList.toggle('is-active', isActive);
-      this.$.content.elevation = isActive ? 1 : 0;
+      // TODO(dbeam): Move to a computeClass_() method + data binding.
+      this.$.content.classList.toggle('is-active', this.isActive_);
+      this.$.content.classList.toggle('dangerous', this.isDangerous_);
+      this.$.content.classList.toggle('show-progress', this.showProgress_);
 
-      // Danger-dependent UI and controls.
-      this.$.content.classList.toggle('dangerous', this.isDangerous_);
-
-      var description = this.getDangerText_(data) || this.getStatusText_(data);
+      var desc = this.getDangerText_(data) || this.getStatusText_(data);
 
       // Status goes in the "tag" (next to the file name) if there's no file.
-      this.ensureTextIs_(this.$.description, isActive ? description : '');
-      this.ensureTextIs_(this.$.tag, isActive ? '' : description);
-
-      this.$.content.classList.toggle('show-progress', this.showProgress_);
+      this.ensureTextIs_(this.$.description, this.isActive_ ? desc : '');
+      this.ensureTextIs_(this.$.tag, this.isActive_ ? '' : desc);
 
       if (!this.isDangerous_) {
-        this.$['file-link'].href = data.url;
-        this.ensureTextIs_(this.$['file-link'], data.file_name);
-
-        this.$['file-link'].hidden = !this.completelyOnDisk_;
-        this.$.name.hidden = this.completelyOnDisk_;
-
         /** @const */ var controlledByExtension = data.by_ext_id &&
                                                   data.by_ext_name;
         this.$['controlled-by'].hidden = !controlledByExtension;
         if (controlledByExtension) {
           var link = this.$['controlled-by'].querySelector('a');
           link.href = 'chrome://extensions#' + data.by_ext_id;
           link.textContent = data.by_ext_name;
         }
 
         var icon = 'chrome://fileicon/' + encodeURIComponent(data.file_path);
         this.iconLoader_.loadScaledIcon(this.$['file-icon'], icon);
       }
     },
 
     /** @private */
     computeCompletelyOnDisk_: function() {
       return this.data_.state == downloads.States.COMPLETE &&
              !this.data_.file_externally_removed;
     },
 
     /** @private */
     computeDate_: function() {
       assert(!this.hideDate);
       return assert(this.data_.since_string || this.data_.date_string);
     },
 
     /** @private */
+    computeElevation_: function() {

[tommycli, 2015/09/09 20:49:16]

I still feel uneasy about this.

But I talked to michaelpg and he agrees with you. This is not a blocker, just a
complaint.

[Dan Beam, 2015/09/09 21:00:15]

Acknowledged.

+      return this.isActive_ ? 1 : 0;
+    },
+
+    /** @private */
+    computeIsActive_: function() {
+      return this.data_.state != downloads.States.CANCELLED &&
+             this.data_.state != downloads.States.INTERRUPTED &&
+             !this.data_.file_externally_removed;
+    },
+
+    /** @private */
     computeIsInProgress_: function() {
       return this.data_.state == downloads.States.IN_PROGRESS;
     },
 
     /** @private */
     computeIsMalware_: function() {
       return this.isDangerous_ &&
           (this.data_.danger_type == downloads.DangerType.DANGEROUS_CONTENT ||
            this.data_.danger_type == downloads.DangerType.DANGEROUS_HOST ||
            this.data_.danger_type == downloads.DangerType.DANGEROUS_URL ||
@@ skipping 158 matching lines @@
     },
 
     /** @private */
     onShowClick_: function() {
       this.actionService_.show(this.data_.id);
     },
   });
 
   return {Item: Item};
 });