Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 1331543002: Copy FrameSelection.{cpp,h} to SelectionEditor.{cpp,h} (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Copy FrameSelection.{cpp,h} to SelectionEditor.{cpp,h} This patch copies "FrameSelection.{cpp,h}" to "SelectionEditor.{cpp,h}" as a preparation of moving |FrameSelection::modify()| to |SelectionEditor| class for inheriting change history. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201858

Patch Set 1 : 2015-09-07T14:25:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + Source/core/editing/SelectionEditor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/editing/SelectionEditor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yoichio
lgtm
5 years, 3 months ago (2015-09-07 05:29:22 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-07 05:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331543002/1
5 years, 3 months ago (2015-09-07 05:38:21 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 05:42:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201858

Powered by Google App Engine
This is Rietveld 408576698