Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1331523002: X87: [es6] Introduce a dedicated JSIteratorResult type. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Introduce a dedicated JSIteratorResult type. port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 (r30557) original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. BUG= Committed: https://crrev.com/691f796f7297ec3076dc23a7d79bb7da7f1d10e1 Cr-Commit-Position: refs/heads/master@{#30610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +41 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:21:33 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331523002/1
5 years, 3 months ago (2015-09-07 07:18:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 08:10:25 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:10:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/691f796f7297ec3076dc23a7d79bb7da7f1d10e1
Cr-Commit-Position: refs/heads/master@{#30610}

Powered by Google App Engine
This is Rietveld 408576698