Make sure GYP supports compiling managed code.

Make sure GYP supports compiling managed code.

The settings were declared but not applied when generating
the project files.

R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/1f374df95de1c0a125485496e8d23d36303a93fd

[Alexis Menard (Chromium), 2015-09-04 16:39:14]

alexis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Alexis Menard (Chromium), 2015-09-04 16:39:14]

I know that Chromium doesn't really need this support, however downstream
projects may want to be able to use GYP to compile managed code.

[Dirk Pranke, 2015-09-04 16:43:53]

dpranke@chromium.org changed reviewers:
+ scottmg@chromium.org

[Dirk Pranke, 2015-09-04 16:44:32]

On 2015/09/04 16:39:14, Alexis Menard (Chromium) wrote:
> I know that Chromium doesn't really need this support, however downstream
> projects may want to be able to use GYP to compile managed code.

I know little about the msvs emulation; scottmg might be a better reviewer.

As an aside, it looks like you may have tried to initiate try jobs through the
rietveld UI. That doesn't currently work, but 'git cl try' should.

[darktears, 2015-09-04 16:48:26]

On 2015/09/04 at 16:44:32, dpranke wrote:
> On 2015/09/04 16:39:14, Alexis Menard (Chromium) wrote:
> > I know that Chromium doesn't really need this support, however downstream
> > projects may want to be able to use GYP to compile managed code.
> 
> I know little about the msvs emulation; scottmg might be a better reviewer.
> 
> As an aside, it looks like you may have tried to initiate try jobs through the
rietveld UI. That doesn't currently work, but 'git cl try' should.

I did run git cl try 

alexisme@alexis-windows MINGW64 ~/Development/gyp (master)
$ git cl try
Tried jobs on:
Master: client.gyp
  linux_try: defaulttests
    mac_try: defaulttests
    win_try: defaulttests

[Dirk Pranke, 2015-09-04 16:55:09]

On 2015/09/04 16:48:26, darktears wrote:
> On 2015/09/04 at 16:44:32, dpranke wrote:
> > On 2015/09/04 16:39:14, Alexis Menard (Chromium) wrote:
> > > I know that Chromium doesn't really need this support, however downstream
> > > projects may want to be able to use GYP to compile managed code.
> > 
> > I know little about the msvs emulation; scottmg might be a better reviewer.
> > 
> > As an aside, it looks like you may have tried to initiate try jobs through
the
> rietveld UI. That doesn't currently work, but 'git cl try' should.
> 
> I did run git cl try 
> 
> alexisme@alexis-windows MINGW64 ~/Development/gyp (master)
> $ git cl try
> Tried jobs on:
> Master: client.gyp
>   linux_try: defaulttests
>     mac_try: defaulttests
>     win_try: defaulttests

Hm. Is it possible you have an old version of depot_tools installed (the
auto-update wasn't working for a while, so you may have to manually to a 'git
pull' in the repo)?

try running with the --use-buildbucket flag? I thought that was the default, but
maybe I'm mistaken.

[scottmg, 2015-09-04 17:16:42]

https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py...
pylib/gyp/msvs_emulation.py:447: 'Safe': '/clr:safe', 'OldSyntax':
'/clr:oldSyntax'})
VS2015 cl /? lists:

/clr[:option] compile for common language runtime, where option is:
    pure - produce IL-only output file (no native executable code)
    safe - produce IL-only verifiable output file
    initialAppDomain - enable initial AppDomain behavior of Visual C++ 2002
    noAssembly - do not produce an assembly
    nostdlib - ignore the default \clr directory

Maybe we should stick to only (false, true, Pure, Safe)?

https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
File test/win/compiler-flags/compile-as-managed.gyp (right):

https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
test/win/compiler-flags/compile-as-managed.gyp:1: # Copyright (c) 2015 Intel
Corporation All rights reserved.
this one too

https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
test/win/compiler-flags/compile-as-managed.gyp:12: 'CompileAsManaged': 'true',
The other settings need to be tested too, preferably with something in the .cc
file that will cause it to fail if it's not valid in pure/safe/etc.

https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
File test/win/gyptest-cl-compile-as-managed.py (right):

https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
test/win/gyptest-cl-compile-as-managed.py:3: # Copyright (c) 2015 Intel
Corporation All rights reserved.
I think this is supposed to be Google for some reason I don't understand.

[Alexis Menard (Chromium), 2015-09-04 17:45:21]

On 2015/09/04 at 17:16:42, scottmg wrote:
> https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py
> File pylib/gyp/msvs_emulation.py (right):
> 
>
https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py...
> pylib/gyp/msvs_emulation.py:447: 'Safe': '/clr:safe', 'OldSyntax':
'/clr:oldSyntax'})
> VS2015 cl /? lists:
> 
> /clr[:option] compile for common language runtime, where option is:
>     pure - produce IL-only output file (no native executable code)
>     safe - produce IL-only verifiable output file
>     initialAppDomain - enable initial AppDomain behavior of Visual C++ 2002
>     noAssembly - do not produce an assembly
>     nostdlib - ignore the default \clr directory
> 
> Maybe we should stick to only (false, true, Pure, Safe)?

Right. After Googling a bit I found :

https://msdn.microsoft.com/en-us/library/k8d11d4s.aspx

Safe and Pure are deprecated and may not be present in future releases.

As this GYP feature is brand new, what about supporting true and false only?

> 
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> File test/win/compiler-flags/compile-as-managed.gyp (right):
> 
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> test/win/compiler-flags/compile-as-managed.gyp:1: # Copyright (c) 2015 Intel
Corporation All rights reserved.
> this one too
> 
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> test/win/compiler-flags/compile-as-managed.gyp:12: 'CompileAsManaged': 'true',
> The other settings need to be tested too, preferably with something in the .cc
file that will cause it to fail if it's not valid in pure/safe/etc.
> 
>
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> File test/win/gyptest-cl-compile-as-managed.py (right):
> 
>
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> test/win/gyptest-cl-compile-as-managed.py:3: # Copyright (c) 2015 Intel
Corporation All rights reserved.
> I think this is supposed to be Google for some reason I don't understand.

I work for Intel but I can put Google if you want to.

[scottmg, 2015-09-04 18:57:29]

On 2015/09/04 17:45:21, Alexis Menard (Chromium) wrote:
> On 2015/09/04 at 17:16:42, scottmg wrote:
> >
https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py
> > File pylib/gyp/msvs_emulation.py (right):
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py...
> > pylib/gyp/msvs_emulation.py:447: 'Safe': '/clr:safe', 'OldSyntax':
> '/clr:oldSyntax'})
> > VS2015 cl /? lists:
> > 
> > /clr[:option] compile for common language runtime, where option is:
> >     pure - produce IL-only output file (no native executable code)
> >     safe - produce IL-only verifiable output file
> >     initialAppDomain - enable initial AppDomain behavior of Visual C++ 2002
> >     noAssembly - do not produce an assembly
> >     nostdlib - ignore the default \clr directory
> > 
> > Maybe we should stick to only (false, true, Pure, Safe)?
> 
> Right. After Googling a bit I found :
> 
> https://msdn.microsoft.com/en-us/library/k8d11d4s.aspx
> 
> Safe and Pure are deprecated and may not be present in future releases.
> 
> As this GYP feature is brand new, what about supporting true and false only?

SGTM.

> 
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > File test/win/compiler-flags/compile-as-managed.gyp (right):
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > test/win/compiler-flags/compile-as-managed.gyp:1: # Copyright (c) 2015 Intel
> Corporation All rights reserved.
> > this one too
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > test/win/compiler-flags/compile-as-managed.gyp:12: 'CompileAsManaged':
'true',
> > The other settings need to be tested too, preferably with something in the
.cc
> file that will cause it to fail if it's not valid in pure/safe/etc.
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> > File test/win/gyptest-cl-compile-as-managed.py (right):
> > 
> >
>
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> > test/win/gyptest-cl-compile-as-managed.py:3: # Copyright (c) 2015 Intel
> Corporation All rights reserved.
> > I think this is supposed to be Google for some reason I don't understand.
> 
> I work for Intel but I can put Google if you want to.

Yeah, I don't care either, but I think that's how the other files are for
whatever reason.

[Alexis Menard (Chromium), 2015-09-04 19:37:23]

On 2015/09/04 at 18:57:29, scottmg wrote:
> On 2015/09/04 17:45:21, Alexis Menard (Chromium) wrote:
> > On 2015/09/04 at 17:16:42, scottmg wrote:
> > >
https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py
> > > File pylib/gyp/msvs_emulation.py (right):
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/pylib/gyp/msvs_emulation.py...
> > > pylib/gyp/msvs_emulation.py:447: 'Safe': '/clr:safe', 'OldSyntax':
> > '/clr:oldSyntax'})
> > > VS2015 cl /? lists:
> > > 
> > > /clr[:option] compile for common language runtime, where option is:
> > >     pure - produce IL-only output file (no native executable code)
> > >     safe - produce IL-only verifiable output file
> > >     initialAppDomain - enable initial AppDomain behavior of Visual C++
2002
> > >     noAssembly - do not produce an assembly
> > >     nostdlib - ignore the default \clr directory
> > > 
> > > Maybe we should stick to only (false, true, Pure, Safe)?
> > 
> > Right. After Googling a bit I found :
> > 
> > https://msdn.microsoft.com/en-us/library/k8d11d4s.aspx
> > 
> > Safe and Pure are deprecated and may not be present in future releases.
> > 
> > As this GYP feature is brand new, what about supporting true and false only?
> 
> SGTM.

Done then.

> 
> > 
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > > File test/win/compiler-flags/compile-as-managed.gyp (right):
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > > test/win/compiler-flags/compile-as-managed.gyp:1: # Copyright (c) 2015
Intel
> > Corporation All rights reserved.
> > > this one too
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/test/win/compiler-flags/com...
> > > test/win/compiler-flags/compile-as-managed.gyp:12: 'CompileAsManaged':
'true',
> > > The other settings need to be tested too, preferably with something in the
.cc
> > file that will cause it to fail if it's not valid in pure/safe/etc.
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> > > File test/win/gyptest-cl-compile-as-managed.py (right):
> > > 
> > >
> >
https://codereview.chromium.org/1331463002/diff/1/test/win/gyptest-cl-compile...
> > > test/win/gyptest-cl-compile-as-managed.py:3: # Copyright (c) 2015 Intel
> > Corporation All rights reserved.
> > > I think this is supposed to be Google for some reason I don't understand.
> > 
> > I work for Intel but I can put Google if you want to.
> 
> Yeah, I don't care either, but I think that's how the other files are for
whatever reason.

Ok then I followed the pattern.

The last changeset should be good now.

[scottmg, 2015-09-04 19:52:54]

https://codereview.chromium.org/1331463002/diff/90001/test/win/compiler-flags...
File test/win/compiler-flags/compile-as-managed.cc (right):

https://codereview.chromium.org/1331463002/diff/90001/test/win/compiler-flags...
test/win/compiler-flags/compile-as-managed.cc:1: // Copyright (c) 2014 Google
Inc. All rights reserved.
2015

https://codereview.chromium.org/1331463002/diff/90001/test/win/gyptest-cl-com...
File test/win/gyptest-cl-compile-as-managed.py (right):

https://codereview.chromium.org/1331463002/diff/90001/test/win/gyptest-cl-com...
test/win/gyptest-cl-compile-as-managed.py:20:
test.build('compile-as-managed.gyp', test.ALL, chdir=CHDIR)
Can you also add a target variant with CompileAsManaged=false, that then here
does a test.build(..., status=1) to test the other code path?

[Alexis Menard (Chromium), 2015-09-04 20:10:12]

On 2015/09/04 at 19:52:54, scottmg wrote:
>
https://codereview.chromium.org/1331463002/diff/90001/test/win/compiler-flags...
> File test/win/compiler-flags/compile-as-managed.cc (right):
> 
>
https://codereview.chromium.org/1331463002/diff/90001/test/win/compiler-flags...
> test/win/compiler-flags/compile-as-managed.cc:1: // Copyright (c) 2014 Google
Inc. All rights reserved.
> 2015
> 

Fixed.

>
https://codereview.chromium.org/1331463002/diff/90001/test/win/gyptest-cl-com...
> File test/win/gyptest-cl-compile-as-managed.py (right):
> 
>
https://codereview.chromium.org/1331463002/diff/90001/test/win/gyptest-cl-com...
> test/win/gyptest-cl-compile-as-managed.py:20:
test.build('compile-as-managed.gyp', test.ALL, chdir=CHDIR)
> Can you also add a target variant with CompileAsManaged=false, that then here
does a test.build(..., status=1) to test the other code path?

Done.

[scottmg, 2015-09-04 20:12:31]

Thanks! LGTM

[scottmg, 2015-09-04 21:24:17]

Committed patchset #7 (id:100001) manually as
1f374df95de1c0a125485496e8d23d36303a93fd (presubmit successful).