Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1331443008: [NaCl SDK] Add msan support to SDK build system (Closed)

Created:
5 years, 3 months ago by Sam Clegg
Modified:
5 years, 3 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add msan support to SDK build system Also fix config name for asan builds CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk Committed: https://crrev.com/bf2db0670c9c9737bb38fedf810157b8115f4054 Cr-Commit-Position: refs/heads/master@{#347817}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M native_client_sdk/src/tools/common.mk View 1 2 chunks +3 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 1 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/host_gcc.mk View 2 chunks +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/tools/sel_ldr.py View 1 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Sam Clegg
5 years, 3 months ago (2015-09-08 14:00:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331443008/1
5 years, 3 months ago (2015-09-08 14:00:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331443008/1
5 years, 3 months ago (2015-09-08 14:01:23 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 16:21:43 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331443008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331443008/20001
5 years, 3 months ago (2015-09-08 17:09:09 UTC) #11
binji
lgtm
5 years, 3 months ago (2015-09-08 17:25:35 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 19:14:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331443008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331443008/20001
5 years, 3 months ago (2015-09-08 22:47:51 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 22:53:55 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 22:54:41 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf2db0670c9c9737bb38fedf810157b8115f4054
Cr-Commit-Position: refs/heads/master@{#347817}

Powered by Google App Engine
This is Rietveld 408576698