Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1331433002: Revert of Speedup stringsearch for two byte strings (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Speedup stringsearch for two byte strings (patchset #3 id:40001 of https://codereview.chromium.org/1303033012/ ) Reason for revert: [Sheriff] Breaks fuzzer and msan: http://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/4773 Repro with: tools/fuzz-harness.sh out/Debug/d8 (in a ninja Debug build) Msan: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/4097 Original issue's description: > Speedup stringsearch for two byte strings > > Uses the lower byte with memchr which is > significantly faster than a naive compare > > Performance difference with bench (http://hastebin.com/xuxexataso.js): > > old new > > single character single character > Κ found at 922 Κ found at 922 > 3324 616 > ㎡ found at 13217 ㎡ found at 13217 > 42366 4931 > က found at 4096 က found at 4096 > 13369 9836 > ＀ found at 65280 ＀ found at 65280 > 207472 36149 > ᆬ found at 65445 ᆬ found at 65445 > 209344 36666 >   found at 8197   found at 8197 > 26731 11757 > 倂 found at 20482 倂 found at 20482 > 66071 17193 > > linear search linear search > ΚΛ found at 922 ΚΛ found at 922 > 4112 504 > ㎡㎢ found at 13217 ㎡㎢ found at 13217 > 55105 5119 > ᆬᆭ found at 65445 ᆬᆭ found at 65445 > 268016 35496 > > linear + bmh search linear + bmh search > ΚΛΜΝΞΟΠΡ found at 922 ΚΛΜΝΞΟΠΡ found at 922 > 2897 522 > ᆬᆭᄃᄄᄅᆰᆱᆲ found at 65445 ᆬᆭᄃᄄᄅᆰᆱᆲ found at 65445 > 167687 158465 > > Committed: https://crrev.com/fced280f37588f8a232a414201276e053117e9ea > Cr-Commit-Position: refs/heads/master@{#30587} TBR=danno@chromium.org,mstarzinger@chromium.org,jkummerow@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/df966cd287d92a4a984955a2cc8405f76dd5955a Cr-Commit-Position: refs/heads/master@{#30588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -49 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M src/string-search.h View 4 chunks +37 lines, -39 lines 0 comments Download
M test/mjsunit/string-indexof-1.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Speedup stringsearch for two byte strings
5 years, 3 months ago (2015-09-04 13:00:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331433002/1
5 years, 3 months ago (2015-09-04 13:00:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 13:00:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df966cd287d92a4a984955a2cc8405f76dd5955a Cr-Commit-Position: refs/heads/master@{#30588}
5 years, 3 months ago (2015-09-04 13:00:45 UTC) #4
Jakob Kummerow
5 years, 3 months ago (2015-09-04 13:12:28 UTC) #5
Message was sent while issue was closed.
Ack, LGTM.

Karl, the workflow for relanding is:
(1) upload the original patch as a new codereview issue (either from a new local
git branch, or after "git cl issue 0" to reset the associated review), issue
description along the lines of: """
Reland 'Speedup string search for two byte strings'

With fixes for out-of-bounds vector access and the uninitialized memory access
reported by MSan.

Original review: https://codereview.chromium.org/1303033012/
"""

(2) fix the problem(s)
(3) upload the fixed version as a new patch set.
(4) get a review as usual (where the reviewer can just compare the two patch
sets, saving time)

Powered by Google App Engine
This is Rietveld 408576698