Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1331403002: Reland of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket (Closed)

Created:
5 years, 3 months ago by hiroshige
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket (patchset #17 id:500001 of https://codereview.chromium.org/736653002/ ) The original CL is reverted (https://codereview.chromium.org/1333153002/): > Reason for revert: > New test on the reference build causing Linux and Mac perf bots to fail. > http://crbug.com/530374 This relanding CL disables blink_perf.pywebsocket tests on reference builds because some tests require Chromium 42, which is newer than reference builds. > This CL adds blink_perf.pywebsocket, in which > - Pywebsocket server is started at localhost:8001, and > - Browser option --disable-web-security is added, > because we need cross-origin accesses between > memory_cache_http_server and pywebsocket server. > > [1/2] PerformanceTests scripts: https://codereview.chromium.org/738753002/ > [2/2] Telemetry: This CL BUG=432408, 530374 TBR=nednguyen@google.com CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect Committed: https://crrev.com/4df951a439d8a09158a1405cad48cf6423d7feb8 Cr-Commit-Position: refs/heads/master@{#348357}

Patch Set 1 : Original CL (736653002) #

Patch Set 2 : Disable on reference builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 3 chunks +40 lines, -0 lines 0 comments Download
A tools/perf/benchmarks/pywebsocket_server.py View 1 chunk +40 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform.py View 3 chunks +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331403002/20001
5 years, 3 months ago (2015-09-11 04:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331403002/20001
5 years, 3 months ago (2015-09-11 05:19:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105791)
5 years, 3 months ago (2015-09-11 06:55:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331403002/20001
5 years, 3 months ago (2015-09-11 07:08:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 07:53:44 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4df951a439d8a09158a1405cad48cf6423d7feb8 Cr-Commit-Position: refs/heads/master@{#348357}
5 years, 3 months ago (2015-09-11 07:54:20 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:20:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4df951a439d8a09158a1405cad48cf6423d7feb8
Cr-Commit-Position: refs/heads/master@{#348357}

Powered by Google App Engine
This is Rietveld 408576698