Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisWorker.java

Issue 13314003: fix for dartbug.com/9512 - don't show errors in packages (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisWorker.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisWorker.java (revision 20660)
+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/builder/AnalysisWorker.java (working copy)
@@ -125,11 +125,13 @@
// TODO (danrubel): log unmatched sources once context only returns errors for added sources
// DartCore.logError("Failed to determine resource for: " + source);
} else {
- LineInfo lineInfo = change.getLineInfo();
- if (lineInfo == null) {
- DartCore.logError("Missing line information for: " + source);
- } else {
- markerManager.queueErrors(res, lineInfo, errors);
+ if (!DartCore.isContainedInPackages(res.getLocation().toFile())) {
+ LineInfo lineInfo = change.getLineInfo();
+ if (lineInfo == null) {
+ DartCore.logError("Missing line information for: " + source);
+ } else {
+ markerManager.queueErrors(res, lineInfo, errors);
+ }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698