Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1331383004: [KeyEvent Mac] Keypad Events have the wrong KeyboardCode (Closed)

Created:
5 years, 3 months ago by dtapuska
Modified:
5 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Keypad keyboard events on Mac; so the KeyboardCodes reflect the Keypad location. Ensure Keypad Events on Mac have the correct keycode associated with them by avoiding the character conversion code and doing the correct check based on the mac KeyCode value. For example '0' as a Keypad character was producing the exact same keycode as '0' as an alpha numeric key because it was compared via the text conversion function first. This code is taken from the WebInputEventFactory.mm in blink. BUG=493833 Committed: https://crrev.com/90aa9cca7416ea267f38e59aded77c17ee10c0ec Cr-Commit-Position: refs/heads/master@{#348798}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M ui/events/keycodes/keyboard_code_conversion_mac.mm View 2 chunks +38 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
dtapuska
5 years, 3 months ago (2015-09-14 18:08:08 UTC) #2
Wez
nit: The CL description is pretty tautogalous; the single line describes the bug, the description ...
5 years, 3 months ago (2015-09-14 21:59:53 UTC) #3
dtapuska
On 2015/09/14 21:59:53, Wez wrote: > nit: The CL description is pretty tautogalous; the single ...
5 years, 3 months ago (2015-09-15 00:37:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331383004/20001
5 years, 3 months ago (2015-09-15 00:39:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 01:12:14 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/90aa9cca7416ea267f38e59aded77c17ee10c0ec Cr-Commit-Position: refs/heads/master@{#348798}
5 years, 3 months ago (2015-09-15 01:13:05 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90aa9cca7416ea267f38e59aded77c17ee10c0ec
Cr-Commit-Position: refs/heads/master@{#348798}

Powered by Google App Engine
This is Rietveld 408576698