Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 133133005: [Android] Remove about:flags entry for low-end device mode (Closed)

Created:
6 years, 11 months ago by jdduke (slow)
Modified:
6 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Remove about:flags entry for low-end device mode Release builds of Android use specialized code for loading shared libraries. The code queries |isLowEndDevice()| before about:flags has propagated to the process command-line, yielding inconsistent low-end device configurations between processes. This can potentially lead to a state where all tabs are blank, forcing the user to re-install Chrome. Remove the about:flags entry until the query can be either deferred or removed entirely. BUG=331931 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jdduke (slow)
yfriedman@: I'd like to disable this entirely until we get a proper solution, in particular ...
6 years, 11 months ago (2014-01-10 16:39:25 UTC) #1
Yaron
lgtm
6 years, 11 months ago (2014-01-10 18:52:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/133133005/1
6 years, 11 months ago (2014-01-10 21:26:29 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 22:00:17 UTC) #4
Message was sent while issue was closed.
Change committed as 244252

Powered by Google App Engine
This is Rietveld 408576698