Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1331313003: Change MSVS visualizers to query y, width and height on WebRect. (Closed)

Created:
5 years, 3 months ago by jbroman
Modified:
5 years, 3 months ago
Reviewers:
zturner
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change MSVS visualizers to query y, width and height on WebRect. Previously these properties all mapped to x. R=zturner@chromium.org Committed: https://crrev.com/cd2e63160220f3b548ca1eb75ec57cd27fed372e Cr-Commit-Position: refs/heads/master@{#348315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/win/DebugVisualizers/webkit.natvis View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jbroman
I saw this while passing by, and it looks "obviously wrong". I don't have a ...
5 years, 3 months ago (2015-09-11 00:42:12 UTC) #1
zturner
On 2015/09/11 00:42:12, jbroman wrote: > I saw this while passing by, and it looks ...
5 years, 3 months ago (2015-09-11 01:50:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331313003/1
5 years, 3 months ago (2015-09-11 02:12:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 02:17:25 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cd2e63160220f3b548ca1eb75ec57cd27fed372e Cr-Commit-Position: refs/heads/master@{#348315}
5 years, 3 months ago (2015-09-11 02:18:17 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:17:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd2e63160220f3b548ca1eb75ec57cd27fed372e
Cr-Commit-Position: refs/heads/master@{#348315}

Powered by Google App Engine
This is Rietveld 408576698