Issue 133123008: Update WebFrameClient::didClearWindowObject signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133123008: Update WebFrameClient::didClearWindowObject signature. (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update WebFrameClient::didClearWindowObject signature. The callback is called both for the main and isolated worlds, the new API indicates in which world the window object was cleared BUG=none R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244485

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+23 lines, -16 lines)			Patch
components/plugins/renderer/webview_plugin.h	View	1 chunk	+1 line, -1 line	0 comments	Download
components/plugins/renderer/webview_plugin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
content/public/renderer/render_view_observer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
content/renderer/cpp_bound_class_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/renderer/java/java_bridge_dispatcher.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/renderer/java/java_bridge_dispatcher.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/renderer/render_frame_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
content/renderer/render_frame_impl.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
content/renderer/render_view_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
content/renderer/render_view_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
content/shell/renderer/shell_render_view_observer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/shell/renderer/shell_render_view_observer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/shell/renderer/webkit_test_runner.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
content/shell/renderer/webkit_test_runner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/133123008/1

6 years, 11 months ago (2014-01-13 10:35:54 UTC) #3

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-13 11:24:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r244485 (presubmit successful).