Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133123004: Implement DriveAppRegistry::UninstallApp() and GetAppList(). (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix build #

Patch Set 3 : Fix after revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -2 lines) Patch
M chrome/browser/drive/drive_app_registry.h View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_app_registry.cc View 1 2 4 chunks +52 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_app_registry_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kinaba
ptal
6 years, 11 months ago (2014-01-10 05:35:05 UTC) #1
hashimoto
lgtm
6 years, 11 months ago (2014-01-10 06:40:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/133123004/1
6 years, 11 months ago (2014-01-10 06:42:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=212550
6 years, 11 months ago (2014-01-10 07:11:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/133123004/260001
6 years, 11 months ago (2014-01-10 09:23:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244729
6 years, 11 months ago (2014-01-10 12:53:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/133123004/260001
6 years, 11 months ago (2014-01-10 14:56:56 UTC) #7
commit-bot: I haz the power
Change committed as 244182
6 years, 11 months ago (2014-01-10 17:08:20 UTC) #8
Marijn Kruisselbrink
A revert of this CL has been created in https://codereview.chromium.org/134213003/ by mek@chromium.org. The reason for ...
6 years, 11 months ago (2014-01-10 17:21:55 UTC) #9
kinaba
On 2014/01/10 17:21:55, Marijn Kruisselbrink wrote: > A revert of this CL has been created ...
6 years, 11 months ago (2014-01-10 22:24:16 UTC) #10
kinaba
6 years, 11 months ago (2014-01-15 03:04:56 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 manually as r244824 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698