Source/core/rendering/shapes/BoxShape.cpp - Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/BoxShape.cpp

Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/shapes/shape-inside/shape-inside-polygon-rounded-first-fit.html ('K') | « Source/core/rendering/shapes/BoxShape.h ('k') | Source/core/rendering/shapes/PolygonShape.h » ('j') | Source/core/rendering/shapes/ShapeInsideInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/shapes/BoxShape.cpp

diff --git a/Source/core/rendering/shapes/BoxShape.cpp b/Source/core/rendering/shapes/BoxShape.cpp

index fac6e129b5661c8c99d29bf10ba9db6a28694ba3..563814048bfcf1f563b1e4b1f3f7de09ce59a0da 100644

--- a/Source/core/rendering/shapes/BoxShape.cpp

+++ b/Source/core/rendering/shapes/BoxShape.cpp

@@ -148,7 +148,7 @@ void BoxShape::getIncludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalHei

result.append(LineSegment(x1, x2));

}

-bool BoxShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTop, const LayoutSize&, LayoutUnit& result) const

+bool BoxShape::firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTop, const FloatSize&, LayoutUnit& result) const

{

// FIXME: this method is only a stub, https://bugs.webkit.org/show_bug.cgi?id=124606.