Source/core/rendering/shapes/PolygonShape.h - Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding

Side by Side Diff: Source/core/rendering/shapes/PolygonShape.h

Issue 133123003: [CSS Shapes] First line gets incorrectly adjusted in shape-inside due to rounding (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/rendering/shapes/BoxShape.cpp ('k') | Source/core/rendering/shapes/PolygonShape.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.	2 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above	8 * 1. Redistributions of source code must retain the above

9 * copyright notice, this list of conditions and the following	9 * copyright notice, this list of conditions and the following

10 * disclaimer.	10 * disclaimer.

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 , m_marginBounds(nullptr)	88 , m_marginBounds(nullptr)

89 , m_paddingBounds(nullptr)	89 , m_paddingBounds(nullptr)

90 {	90 {

91 }	91 }

92	92

93 virtual LayoutRect shapeMarginLogicalBoundingBox() const OVERRIDE { return s tatic_cast<LayoutRect>(shapeMarginBounds().boundingBox()); }	93 virtual LayoutRect shapeMarginLogicalBoundingBox() const OVERRIDE { return s tatic_cast<LayoutRect>(shapeMarginBounds().boundingBox()); }

94 virtual LayoutRect shapePaddingLogicalBoundingBox() const OVERRIDE { return static_cast<LayoutRect>(shapePaddingBounds().boundingBox()); }	94 virtual LayoutRect shapePaddingLogicalBoundingBox() const OVERRIDE { return static_cast<LayoutRect>(shapePaddingBounds().boundingBox()); }

95 virtual bool isEmpty() const OVERRIDE { return m_polygon.isEmpty(); }	95 virtual bool isEmpty() const OVERRIDE { return m_polygon.isEmpty(); }

96 virtual void getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalH eight, SegmentList&) const OVERRIDE;	96 virtual void getExcludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalH eight, SegmentList&) const OVERRIDE;

97 virtual void getIncludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalH eight, SegmentList&) const OVERRIDE;	97 virtual void getIncludedIntervals(LayoutUnit logicalTop, LayoutUnit logicalH eight, SegmentList&) const OVERRIDE;

98 virtual bool firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTo p, const LayoutSize& minLogicalIntervalSize, LayoutUnit&) const OVERRIDE;	98 virtual bool firstIncludedIntervalLogicalTop(LayoutUnit minLogicalIntervalTo p, const FloatSize& minLogicalIntervalSize, LayoutUnit&) const OVERRIDE;

99	99

100 private:	100 private:

101 const FloatPolygon& shapeMarginBounds() const;	101 const FloatPolygon& shapeMarginBounds() const;

102 const FloatPolygon& shapePaddingBounds() const;	102 const FloatPolygon& shapePaddingBounds() const;

103	103

104 FloatPolygon m_polygon;	104 FloatPolygon m_polygon;

105 mutable OwnPtr<FloatPolygon> m_marginBounds;	105 mutable OwnPtr<FloatPolygon> m_marginBounds;

106 mutable OwnPtr<FloatPolygon> m_paddingBounds;	106 mutable OwnPtr<FloatPolygon> m_paddingBounds;

107 };	107 };

108	108

109 } // namespace WebCore	109 } // namespace WebCore

110	110

111 #endif // PolygonShape_h	111 #endif // PolygonShape_h

OLD	NEW