build/android/adb_reverse_forwarder.py - Issue 1331213004: [Android] Don't use a device blacklist if one isn't provided. (RELAND 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_reverse_forwarder.py

Issue 1331213004: [Android] Don't use a device blacklist if one isn't provided. (RELAND 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: + adb_install_apk.py blacklist Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/adb_reverse_forwarder.py

diff --git a/build/android/adb_reverse_forwarder.py b/build/android/adb_reverse_forwarder.py

index 0ebe56d094145f74fd53a5e3aa4a0164acf04cf7..64718f575dd4b2921e2a1934fe0f24902a3048c0 100755

--- a/build/android/adb_reverse_forwarder.py

+++ b/build/android/adb_reverse_forwarder.py

@@ -55,11 +55,9 @@ def main(argv):

parser.error('Bad port number')

sys.exit(1)

- if options.blacklist_file:

- blacklist = device_blacklist.Blacklist(options.blacklist_file)

- else:

- blacklist = None

+ blacklist = (device_blacklist.Blacklist(options.blacklist_file)

+ if options.blacklist_file

+ else None)

devices = device_utils.DeviceUtils.HealthyDevices(blacklist)

if options.device:

« no previous file with comments | « build/android/adb_install_apk.py ('k') | build/android/buildbot/bb_device_status_check.py » ('j') | no next file with comments »