Expose the V8 script context from WebRemoteFrame.

The current implementation of <webview> relies on being able to access the V8 
script context of the swapped out RenderFrame representing the frame in the 
remote process.

When swapped out is disabled, there is no longer a RenderFrame, but we have
RenderFrameProxy, which is backed by WebRemoteFrame. As such, to avoid breaking
<webview>, it must be possible to get the V8 script context from a WebRemoteFrame.
This CL adds such a method, which should not be used by any other code. Once the
full migration of <webview> from BrowserPlugin to out-of-process iframes is
complete, we can remove this method.

BUG=357747
Committed: https://crrev.com/6872b83c0220dfe12f09ae29727f638f8df93e26
git-svn-id: svn://svn.chromium.org/blink/trunk@202163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[nasko, 2015-09-11 16:49:29]

nasko@chromium.org changed reviewers:
+ dcheng@chromium.org

[nasko, 2015-09-11 16:49:29]

Hey Daniel,
Can you review this CL for me? 
Thanks in advance!
Nasko

[nasko, 2015-09-11 16:49:34]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-11 16:49:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331213002/1

[commit-bot: I haz the power, 2015-09-11 18:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 18:08:40]

Dry run: This issue passed the CQ dry run.

[dcheng, 2015-09-11 18:10:53]

lgtm

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h
File public/web/WebRemoteFrame.h (right):

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h...
public/web/WebRemoteFrame.h:47: // This method is only temporary, until
<webview> is migrated over to
Suggested comment: Temporary method to allow embedders to get the script context
of a remote frame. This should only be used by legacy code that has not yet
migrated over to the new OOPI infrastructure.

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h...
public/web/WebRemoteFrame.h:49: virtual v8::Local<v8::Context>
doNotUseMainWorldScriptContext() const = 0;
I suggest naming this deprecatedMainWorldScriptContext(): it fits in a bit
better with the naming conventions and should sufficiently convey that this is a
stopgap.

[nasko, 2015-09-11 18:24:31]

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h
File public/web/WebRemoteFrame.h (right):

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h...
public/web/WebRemoteFrame.h:47: // This method is only temporary, until
<webview> is migrated over to
On 2015/09/11 18:10:53, dcheng wrote:
> Suggested comment: Temporary method to allow embedders to get the script
context
> of a remote frame. This should only be used by legacy code that has not yet
> migrated over to the new OOPI infrastructure.

Done.

https://codereview.chromium.org/1331213002/diff/1/public/web/WebRemoteFrame.h...
public/web/WebRemoteFrame.h:49: virtual v8::Local<v8::Context>
doNotUseMainWorldScriptContext() const = 0;
On 2015/09/11 18:10:53, dcheng wrote:
> I suggest naming this deprecatedMainWorldScriptContext(): it fits in a bit
> better with the naming conventions and should sufficiently convey that this is
a
> stopgap.

Done.

[nasko, 2015-09-11 18:25:22]

The CQ bit was checked by nasko@chromium.org

[nasko, 2015-09-11 18:25:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1331213002/#ps20001
(title: "Changes based on Daniel's review.")

[commit-bot: I haz the power, 2015-09-11 18:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331213002/20001

[commit-bot: I haz the power, 2015-09-11 20:51:18]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202163

[commit-bot: I haz the power, 2015-09-23 12:26:17]

Patchset 2 (id:??) landed as
https://crrev.com/6872b83c0220dfe12f09ae29727f638f8df93e26