Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1331203003: Set autoplay gesture override experiment based on finch trial group. (Closed)

Created:
5 years, 3 months ago by liberato (no reviews please)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set autoplay gesture override experiment based on finch trial group. This CL uses the finch trial group name to set WebKit settings for the android autoplay gesture override experiment. Most of the code for the experiment itself is in https://codereview.chromium.org/1179223002/ . The present CL will not build without it. Summary of the experiment: Our goal is to decide if the requirement for a user gesture can be relaxed on android, to allow some media to autoplay without always requiring the user to interact with it manuall. The finch experiment will let us try various combinations of heuristics for when to autoplay without a user gesture. We record metrics based on user behavior, such as "manually started playback", "manually stopped playback", etc. These options are composible, so we just use the trial group name to specify the options directly. This lets us try different combinations after we get some initial data from the experiment. BUG=487345, 402044 Committed: https://crrev.com/6524fa4de84e68577cdfcc405be2f3b5cb167f73 Cr-Commit-Position: refs/heads/master@{#348762}

Patch Set 1 #

Patch Set 2 : ase => base (must have :wq when i meant to :q!) #

Patch Set 3 : updated histograms.xml. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
liberato (no reviews please)
Hi all I'd appreciate it if each of you could provide owner feedback on (at ...
5 years, 3 months ago (2015-09-10 21:44:35 UTC) #3
rkaplow
lgtm histogram lgtm
5 years, 3 months ago (2015-09-11 21:03:28 UTC) #4
Will Harris
content/public/common/common_param_traits_macros.h lgtm
5 years, 3 months ago (2015-09-11 22:14:23 UTC) #5
davidben
lgtm
5 years, 3 months ago (2015-09-11 22:48:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331203003/40001
5 years, 3 months ago (2015-09-14 17:21:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/106734)
5 years, 3 months ago (2015-09-14 19:16:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331203003/40001
5 years, 3 months ago (2015-09-14 22:53:05 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 23:26:16 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6524fa4de84e68577cdfcc405be2f3b5cb167f73 Cr-Commit-Position: refs/heads/master@{#348762}
5 years, 3 months ago (2015-09-14 23:27:02 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:38:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6524fa4de84e68577cdfcc405be2f3b5cb167f73
Cr-Commit-Position: refs/heads/master@{#348762}

Powered by Google App Engine
This is Rietveld 408576698