Don't use $USER for Local Login check

remoting/host/pam_authorization_factory_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/pam_authorization_factory_posix.h"
 
 #include <security/pam_appl.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/environment.h"
 #include "base/logging.h"
+#include "remoting/base/util.h"
 #include "remoting/protocol/channel_authenticator.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
 
 namespace remoting {
 
 namespace {
 class PamAuthorizer : public protocol::Authenticator {
  public:
   PamAuthorizer(scoped_ptr<protocol::Authenticator> underlying);
   virtual ~PamAuthorizer();
@@ skipping 71 matching lines @@
   return underlying_->CreateChannelAuthenticator();
 }
 
 void PamAuthorizer::MaybeCheckLocalLogin() {
   if (local_login_status_ == NOT_CHECKED && state() == ACCEPTED) {
     local_login_status_ = IsLocalLoginAllowed() ? ALLOWED : DISALLOWED;
   }
 }
 
 bool PamAuthorizer::IsLocalLoginAllowed() {
-  std::string username;
-  if (!base::Environment::Create()->GetVar("USER", &username)) {
+  std::string username = GetUsername();
+  if (username.empty())

[Wez, 2013/03/29 17:27:57]

This if() differs in style from other single-line ifs in this file.  Please
either match the existing style or, preferably, update the existing if()s to
match this one.

[Jamie, 2013/03/29 18:30:00]

I disagree with your use of the word "preferably" :)

[Lambros, 2013/03/29 19:30:22]

Done.

     return false;
-  }
 
   struct pam_conv conv = { PamConversation, NULL };
   pam_handle_t* handle = NULL;
   int result = pam_start("chrome-remote-desktop", username.c_str(),
                          &conv, &handle);
   if (result == PAM_SUCCESS) {
     result = pam_acct_mgmt(handle, 0);
   }
   pam_end(handle, result);
 
@@ skipping 47 matching lines @@
     const std::string& remote_jid,
     const buzz::XmlElement* first_message) {
   scoped_ptr<protocol::Authenticator> authenticator(
       underlying_->CreateAuthenticator(local_jid, remote_jid, first_message));
   return scoped_ptr<protocol::Authenticator>(
       new PamAuthorizer(authenticator.Pass()));
 }
 
 
 }  // namespace remoting