Add tracking of open processes to the new io resource tracking.

Add tracking of open processes to the new io resource tracking.

I plan on refactoring the io_resource_info.dart file a bit in a follow up, but I keept this simple

I also plan on adding some sort of sanity checking when the vm exits, to make sure
all 3 maps are empty (in debug mode)

This fixes issue #24314, before we would hold on to process that failed to start
running in the _processes map.

Closes #24314
BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/38b579fa783b1ecc5d3e0b6945c5b31ca539615b

[ricow1, 2015-09-10 13:20:32]

ricow@google.com changed reviewers:
+ sgjesse@google.com

[Cutch, 2015-09-10 16:49:40]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-09-10 16:49:41]

LGTM with some nits

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/process_service_test.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:64: var all = await
isolate.invokeRpcNoUpgrade('__getStartedProcesses', {});
Maybe '_getProcesses' ?

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:65:
expect(all['type'], equals('_startedprocesses'));
Maybe '_Process' ?

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
File sdk/lib/io/io_resource_info.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:43: _IOResourceInfo._sw.elapsedMicroseconds /
1000000.0;
All times reported over the service protocol should be expressed as milliseconds
since the epoch and transmitted as doubles. We need this so we can reconstruct
the DateTime object in the UI (running as JavaScript).

[Søren Gjesse, 2015-09-10 17:43:35]

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/process_service_test.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:50: void
expectTimeBiggerThanZero(time) {
This function is not used in this test.

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:72:
expect(first['pid'], greaterThan(0));
Couldn't you somehow also check the pid?

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:81: 
Can the test be extended to also test what happens when the processes stop?
Maybe instead of using --pause_isolates_on_start run some code which reads from
stdin, and terminate when stdin is closed.

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
File sdk/lib/io/io_resource_info.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:149: startedAt =
_IOResourceInfo._sw.elapsedMicroseconds / 1000000.0,
This looks more like the current running time instead of start time. Maybe just
storing the start time will be fine. The UI can calculate running time from
that.

[ricow1, 2015-09-14 07:01:17]

thanks for comments, updated accordingly

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/process_service_test.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:50: void
expectTimeBiggerThanZero(time) {
On 2015/09/10 17:43:34, Søren Gjesse wrote:
> This function is not used in this test.

Done.

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:64: var all = await
isolate.invokeRpcNoUpgrade('__getStartedProcesses', {});
On 2015/09/10 16:49:41, Cutch wrote:
> Maybe '_getProcesses' ?

Done.

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:65:
expect(all['type'], equals('_startedprocesses'));
On 2015/09/10 16:49:41, Cutch wrote:
> Maybe '_Process' ?

Changed to processes - this is after all, more than one. I actually want to
discuss the structure of this with you, it seems you have to send a map. Let us
talk about this in our next meeting

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:72:
expect(first['pid'], greaterThan(0));
On 2015/09/10 17:43:34, Søren Gjesse wrote:
> Couldn't you somehow also check the pid?

Done

https://codereview.chromium.org/1331033003/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/process_service_test.dart:81: 
On 2015/09/10 17:43:34, Søren Gjesse wrote:
> Can the test be extended to also test what happens when the processes stop?
> Maybe instead of using --pause_isolates_on_start run some code which reads
from
> stdin, and terminate when stdin is closed.

Done.

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
File sdk/lib/io/io_resource_info.dart (right):

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:43: _IOResourceInfo._sw.elapsedMicroseconds /
1000000.0;
On 2015/09/10 16:49:41, Cutch wrote:
> All times reported over the service protocol should be expressed as
milliseconds
> since the epoch and transmitted as doubles. We need this so we can reconstruct
> the DateTime object in the UI (running as JavaScript).
I will change this in a follow up to be consistent across the board (I need to
change the tests a bit for the other resource classes as well, I don't want to
mix it with this). I have changed if for the process though, to be that time

https://codereview.chromium.org/1331033003/diff/20001/sdk/lib/io/io_resource_...
sdk/lib/io/io_resource_info.dart:149: startedAt =
_IOResourceInfo._sw.elapsedMicroseconds / 1000000.0,
On 2015/09/10 17:43:35, Søren Gjesse wrote:
> This looks more like the current running time instead of start time. Maybe
just
> storing the start time will be fine. The UI can calculate running time from
> that.
done

[ricow1, 2015-09-14 10:54:44]

Committed patchset #3 (id:40001) manually as
38b579fa783b1ecc5d3e0b6945c5b31ca539615b (presubmit successful).