[KeyEvent Mac] Move WebInputEventFactory into chromium.

content/browser/renderer_host/input/web_input_event_builders_mac.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_WEB_INPUT_EVENT_BUILDERS_MAC_H_
+#define CONTENT_BROWSER_RENDERER_HOST_INPUT_WEB_INPUT_EVENT_BUILDERS_MAC_H_
+
+#include "content/common/content_export.h"
+#include "third_party/WebKit/public/web/WebInputEvent.h"
+
+#ifdef __OBJC__
+@class NSEvent;
+@class NSView;
+#else

[Alexei Svitkine (slow), 2015/09/14 18:54:03]

Hmm, this file isn't being included in any non-Objc files, so I'd just drop the
#ifdef altogether and it's else clause.

[dtapuska, 2015/09/14 19:26:46]

No this isn't possible the implementation mm file includes this file.

[Alexei Svitkine (slow), 2015/09/14 19:32:56]

My point is to only have:

@class NSEvent;
@class NSView;

Without the #else clause. Since all the includes of this header are in .mm files
(including its impl), they should all understand the @class syntax and there
shouldn't be any issues. Or am I missing something?

[dtapuska, 2015/09/14 19:40:07]

Done.

+class NSEvent;
+class NSView;
+#endif
+
+namespace content {
+
+class CONTENT_EXPORT WebKeyboardEventBuilder {
+ public:
+  static blink::WebKeyboardEvent Build(NSEvent*);

[Alexei Svitkine (slow), 2015/09/14 18:54:03]

Nit: In Chromium code, keep the param names in the headers. Please fix all the
functions in this file.

[dtapuska, 2015/09/14 19:26:46]

Done.

+};
+
+class CONTENT_EXPORT WebMouseEventBuilder {
+ public:
+  static blink::WebMouseEvent Build(NSEvent*, NSView*);
+};
+
+class CONTENT_EXPORT WebMouseWheelEventBuilder {
+ public:
+  static blink::WebMouseWheelEvent Build(NSEvent*,
+                                         NSView*,
+                                         bool canRubberbandLeft,

[Alexei Svitkine (slow), 2015/09/14 18:54:03]

Nit: can_rubberband_left same for the next param.

[dtapuska, 2015/09/14 19:26:46]

Done.

+                                         bool canRubberbandRight);
+};
+
+class CONTENT_EXPORT WebGestureEventBuilder {
+ public:
+  static blink::WebGestureEvent Build(NSEvent*, NSView*);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_RENDERER_HOST_INPUT_WEB_INPUT_EVENT_BUILDERS_MAC_H_