Continuing removing deprecated functions from cctests

Continuing removing deprecated functions from cctests

Removes deprecated functions from:
- test-unique.cc
- test-unscopables-hidden-prototype.cc
- test-utils-arm64.cc
- test-utils.cc
- test-version.cc
- test-weakmaps.cc
- test-weaksets.cc
- trace-extension.cc
- trace-extension.h

BUG=v8:4134
LOG=n

Committed: https://crrev.com/edb30522f9fd4a1f27abbf18683239388c67ca00
Cr-Commit-Position: refs/heads/master@{#30681}

[mythria_google, 2015-09-10 09:07:42]

mythria@google.com changed reviewers:
+ rmcilroy@chromium.org

[mythria_google, 2015-09-10 09:07:42]

Please review the changes and let me know any corrections

[rmcilroy, 2015-09-10 09:30:16]

rmcilroy@chromium.org changed reviewers:
+ jochen@chromium.org

[rmcilroy, 2015-09-10 09:30:16]

Looks good overall, just a couple of nits.

Jochen, do you want to give it a once over too (If you are fine with the
approach I'll not bother you with future ones).

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
File test/cctest/test-unscopables-hidden-prototype.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:29: v8::Local<v8::Context>
curr_context = isolate->GetCurrentContext();
nit - please don't abbreviate - current_context.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
Could you add a CHECK() around this to check the value returned is true.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
nit - could .FromMaybe(-1) be on the same line as ->Int32Value couldn't it (or
did git cl format do this to you)?

https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc
File test/cctest/trace-extension.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension...
test/cctest/trace-extension.cc:53: .FromMaybe(false)) {
nit - could .FromMaybe(..) go on the same line as .ToLocalChecked() here too?

[jochen (gone - plz use gerrit), 2015-09-10 09:33:24]

overall looks good

can you please run tryjobs?

ToLocalChecked() corresponds to FromJust() which checks that the Maybe<> value
is "just", so I'd use that where possible.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
File test/cctest/test-unscopables-hidden-prototype.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 at 09:30:16, rmcilroy wrote:
> Could you add a CHECK() around this to check the value returned is true.

Just use .FromJust() that checks internally.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 at 09:30:16, rmcilroy wrote:
> nit - could .FromMaybe(-1) be on the same line as ->Int32Value couldn't it (or
did git cl format do this to you)?

same here... FromJust()

[rmcilroy, 2015-09-10 09:37:54]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-10 09:38:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331013003/1

[rmcilroy, 2015-09-10 09:38:37]

> can you please run tryjobs?

I kicked these for Mythri (I don't think she has permission yet).

[commit-bot: I haz the power, 2015-09-10 10:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 10:02:57]

Dry run: This issue passed the CQ dry run.

[mythria_google, 2015-09-10 10:07:30]

Thanks for the quick review. I addressed all the comments.

I just have one question regarding the formatting here

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...

Could you please quickly guide me on this

Thanks and Regards,
Mythri

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
File test/cctest/test-unscopables-hidden-prototype.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:29: v8::Local<v8::Context>
curr_context = isolate->GetCurrentContext();
On 2015/09/10 09:30:16, rmcilroy wrote:
> nit - please don't abbreviate - current_context.

Done.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 09:30:16, rmcilroy wrote:
> Could you add a CHECK() around this to check the value returned is true.

Done.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:45:
object->SetPrototype(curr_context, hidden_prototype).FromMaybe(false);
On 2015/09/10 09:33:24, jochen wrote:
> On 2015/09/10 at 09:30:16, rmcilroy wrote:
> > Could you add a CHECK() around this to check the value returned is true.
> 
> Just use .FromJust() that checks internally.

Done.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 09:33:24, jochen wrote:
> On 2015/09/10 at 09:30:16, rmcilroy wrote:
> > nit - could .FromMaybe(-1) be on the same line as ->Int32Value couldn't it
(or
> did git cl format do this to you)?
> 
> same here... FromJust()

Done.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
On 2015/09/10 09:30:16, rmcilroy wrote:
> nit - could .FromMaybe(-1) be on the same line as ->Int32Value couldn't it (or
> did git cl format do this to you)?

This is git cl format. I can move FromMaybe to the earlier line. Should I also
move ->Int32Vale(current_contex).FroMaybe(-1) to the earlier line? It still fits
in 80 character limit. I am not sure about formatting guidelines for these.

https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension.cc
File test/cctest/trace-extension.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/trace-extension...
test/cctest/trace-extension.cc:53: .FromMaybe(false)) {
On 2015/09/10 09:30:16, rmcilroy wrote:
> nit - could .FromMaybe(..) go on the same line as .ToLocalChecked() here too?

Done.

[rmcilroy, 2015-09-10 10:41:05]

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
File test/cctest/test-unscopables-hidden-prototype.cc (right):

https://codereview.chromium.org/1331013003/diff/1/test/cctest/test-unscopable...
test/cctest/test-unscopables-hidden-prototype.cc:62: .FromMaybe(-1));
If this is what git cl format wants then I'm fine with it :).

[rmcilroy, 2015-09-10 11:03:46]

lgtm, thanks!

[mythria_google, 2015-09-10 12:36:37]

The CQ bit was checked by mythria@google.com

[commit-bot: I haz the power, 2015-09-10 12:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331013003/20001

[commit-bot: I haz the power, 2015-09-10 13:09:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-10 13:10:09]

Patchset 2 (id:??) landed as
https://crrev.com/edb30522f9fd4a1f27abbf18683239388c67ca00
Cr-Commit-Position: refs/heads/master@{#30681}