Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 1330993004: X87: On a call to Array(), we patched a call ic. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: On a call to Array(), we patched a call ic. port ba7b64139886ab7987406a92bf0e801b807c9fe4 (r30649) original commit message: This CL makes do with a single dispatcher which inlines the special handling for the Array() call case, loading the allocation site found in the vector and c BUG= Committed: https://crrev.com/cfbe3f64437c963bc36ba7f2644da871bafc8877 Cr-Commit-Position: refs/heads/master@{#30672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M src/x87/code-stubs-x87.cc View 5 chunks +17 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-10 08:07:14 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-10 08:13:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330993004/1
5 years, 3 months ago (2015-09-10 08:13:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 08:39:57 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 08:40:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfbe3f64437c963bc36ba7f2644da871bafc8877
Cr-Commit-Position: refs/heads/master@{#30672}

Powered by Google App Engine
This is Rietveld 408576698