Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1330953002: Mac Overlays: Allow multiple overlays with sandwich strategy. (Closed)

Created:
5 years, 3 months ago by Andre
Modified:
5 years, 3 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Mac Overlays: Allow multiple overlays with sandwich strategy. Allow multiple videos to be promoted to overlays, as long as they don't overlap. BUG=527222 TBR=ccameron@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1304053016 Cr-Commit-Position: refs/heads/master@{#347805} (cherry picked from commit 99750ddf53c9901b1e9f70c2f3c038f24df2c623) Conflicts: cc/output/overlay_strategy_sandwich.cc cc/output/overlay_strategy_single_on_top.cc cc/output/overlay_strategy_underlay.cc Committed: https://chromium.googlesource.com/chromium/src/+/5659db2cd868019dea23795c470e91ff1577003a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -121 lines) Patch
M cc/output/overlay_strategy_common.h View 2 chunks +20 lines, -11 lines 0 comments Download
M cc/output/overlay_strategy_common.cc View 4 chunks +37 lines, -20 lines 0 comments Download
M cc/output/overlay_strategy_sandwich.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/output/overlay_strategy_sandwich.cc View 5 chunks +34 lines, -32 lines 0 comments Download
M cc/output/overlay_strategy_single_on_top.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/output/overlay_strategy_single_on_top.cc View 1 chunk +15 lines, -22 lines 0 comments Download
M cc/output/overlay_strategy_underlay.h View 1 chunk +6 lines, -6 lines 0 comments Download
M cc/output/overlay_strategy_underlay.cc View 1 chunk +14 lines, -18 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330953002/1
5 years, 3 months ago (2015-09-09 20:01:44 UTC) #2
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
5 years, 3 months ago (2015-09-09 20:01:45 UTC) #4
Andre
5 years, 3 months ago (2015-09-10 02:13:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5659db2cd868019dea23795c470e91ff1577003a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698