Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: content/worker/websharedworker_stub.cc

Issue 133093003: Move the worker script loading code to the worker process (phase:4/5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02ScriptLoadInWorkerChrome
Patch Set: change comments in worker_webapplicationcachehost_impl.h and rebase. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/worker/websharedworker_stub.cc
diff --git a/content/worker/websharedworker_stub.cc b/content/worker/websharedworker_stub.cc
index 5f40bab0e49f1ee78d7e63552eb9f026e8e3f75a..19d3ec988cdac9b33b614524cc339de493b09f56 100644
--- a/content/worker/websharedworker_stub.cc
+++ b/content/worker/websharedworker_stub.cc
@@ -23,14 +23,11 @@ WebSharedWorkerStub::WebSharedWorkerStub(
const base::string16& name,
const base::string16& content_security_policy,
blink::WebContentSecurityPolicyType security_policy_type,
- int route_id,
- const WorkerAppCacheInitInfo& appcache_init_info)
+ int route_id)
: route_id_(route_id),
- appcache_init_info_(appcache_init_info),
client_(route_id, this),
- name_(name),
- started_(false),
- worker_script_loaded_(false) {
+ running_(false),
+ url_(url) {
WorkerThread* worker_thread = WorkerThread::current();
DCHECK(worker_thread);
@@ -42,6 +39,8 @@ WebSharedWorkerStub::WebSharedWorkerStub(
impl_ = blink::WebSharedWorker::create(client());
worker_devtools_agent_.reset(new SharedWorkerDevToolsAgent(route_id, impl_));
client()->set_devtools_agent(worker_devtools_agent_.get());
+ impl_->startWorkerContext(url_, name,
+ content_security_policy, security_policy_type);
}
WebSharedWorkerStub::~WebSharedWorkerStub() {
@@ -67,7 +66,6 @@ bool WebSharedWorkerStub::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(WebSharedWorkerStub, message)
- IPC_MESSAGE_HANDLER(WorkerMsg_StartWorkerContext, OnStartWorkerContext)
IPC_MESSAGE_HANDLER(WorkerMsg_TerminateWorkerContext,
OnTerminateWorkerContext)
IPC_MESSAGE_HANDLER(WorkerMsg_Connect, OnConnect)
@@ -84,29 +82,16 @@ const GURL& WebSharedWorkerStub::url() {
return url_;
}
-void WebSharedWorkerStub::OnStartWorkerContext(
- const GURL& url, const base::string16& user_agent,
- const base::string16& source_code,
- const base::string16& content_security_policy,
- blink::WebContentSecurityPolicyType policy_type) {
- // Ignore multiple attempts to start this worker (can happen if two pages
- // try to start it simultaneously).
- if (started_)
- return;
-
- impl_->startWorkerContext(url, name_, user_agent, source_code,
- content_security_policy, policy_type, 0);
- started_ = true;
- url_ = url;
-}
-
void WebSharedWorkerStub::OnConnect(int sent_message_port_id, int routing_id) {
- blink::WebMessagePortChannel* channel =
+ WebMessagePortChannelImpl* channel =
new WebMessagePortChannelImpl(routing_id,
sent_message_port_id,
base::MessageLoopProxy::current().get());
- if (started_ && worker_script_loaded_) {
+ if (running_) {
impl_->connect(channel);
+ WorkerThread::current()->Send(
+ new WorkerHostMsg_WorkerConnected(channel->message_port_id(),
+ route_id_));
} else {
// If two documents try to load a SharedWorker at the same time, the
// WorkerMsg_Connect for one of the documents can come in before the
@@ -121,22 +106,32 @@ void WebSharedWorkerStub::OnTerminateWorkerContext() {
// Call the client to make sure context exits.
EnsureWorkerContextTerminates();
- started_ = false;
+ running_ = false;
}
void WebSharedWorkerStub::WorkerScriptLoaded() {
- worker_script_loaded_ = true;
+ running_ = true;
// Process any pending connections.
for (PendingChannelList::const_iterator iter = pending_channels_.begin();
iter != pending_channels_.end();
++iter) {
impl_->connect(*iter);
+ WorkerThread::current()->Send(
+ new WorkerHostMsg_WorkerConnected((*iter)->message_port_id(),
+ route_id_));
}
pending_channels_.clear();
}
void WebSharedWorkerStub::WorkerScriptLoadFailed() {
- // FIXME(horo): Implement this.
+ for (PendingChannelList::const_iterator iter = pending_channels_.begin();
+ iter != pending_channels_.end();
+ ++iter) {
+ blink::WebMessagePortChannel* channel = *iter;
+ channel->destroy();
+ }
+ pending_channels_.clear();
+ Shutdown();
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698