Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: content/common/view_messages.h

Issue 133093003: Move the worker script loading code to the worker process (phase:4/5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02ScriptLoadInWorkerChrome
Patch Set: change comments in worker_webapplicationcachehost_impl.h and rebase. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index f88bc9b694a94b1dc7d4e5113ad23a0e65c3ff6e..e17a91f7988fdcee6f36b5c141b8f6a436f6ed75 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -354,14 +354,6 @@ IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)
// RenderFrame routing id used to send messages back to the parent.
IPC_STRUCT_MEMBER(int, render_frame_route_id)
-
- // The route ID to associate with the worker. If MSG_ROUTING_NONE is passed,
- // a new unique ID is created and assigned to the worker.
- IPC_STRUCT_MEMBER(int, route_id)
-
- // The ID of the appcache the main shared worker script resource was loaded
- // from, only valid for shared workers.
- IPC_STRUCT_MEMBER(int64, script_resource_appcache_id)
IPC_STRUCT_END()
IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeDialogValue_Params)
@@ -1171,10 +1163,21 @@ IPC_MESSAGE_ROUTED1(ViewMsg_DisableScrollbarsForSmallWindows,
IPC_MESSAGE_ROUTED1(ViewMsg_SetActive,
bool /* active */)
-// Response message to ViewHostMsg_CreateShared/DedicatedWorker.
+// Response message to ViewHostMsg_CreateWorker.
// Sent when the worker has started.
IPC_MESSAGE_ROUTED0(ViewMsg_WorkerCreated)
+// Sent when the worker failed to load the worker script.
+// In normal cases, this message is sent after ViewMsg_WorkerCreated is sent.
+// But if the shared worker of the same URL already exists and it has failed
+// to load the script, when the renderer send ViewHostMsg_CreateWorker before
+// the shared worker is killed only ViewMsg_WorkerScriptLoadFailed is sent.
+IPC_MESSAGE_ROUTED0(ViewMsg_WorkerScriptLoadFailed)
+
+// Sent when the worker has connected.
+// This message is sent only if the worker successfully loaded the script.
+IPC_MESSAGE_ROUTED0(ViewMsg_WorkerConnected)
+
// Tells the renderer that the network state has changed and that
// window.navigator.onLine should be updated for all WebViews.
IPC_MESSAGE_CONTROL1(ViewMsg_NetworkStateChanged,
@@ -1671,21 +1674,6 @@ IPC_SYNC_MESSAGE_CONTROL1_1(ViewHostMsg_CreateWorker,
ViewHostMsg_CreateWorker_Params,
int /* route_id */)
-// This message is sent to the browser to see if an instance of this shared
-// worker already exists. If so, it returns exists == true. If a
-// non-empty name is passed, also validates that the url matches the url of
-// the existing worker. If a matching worker is found, the passed-in
-// document_id is associated with that worker, to ensure that the worker
-// stays alive until the document is detached.
-// The route_id returned can be used to forward messages to the worker via
-// ForwardToWorker if it exists, otherwise it should be passed in to any
-// future call to CreateWorker to avoid creating duplicate workers.
-IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LookupSharedWorker,
- ViewHostMsg_CreateWorker_Params,
- bool /* exists */,
- int /* route_id */,
- bool /* url_mismatch */)
-
// A renderer sends this to the browser process when a document has been
// detached. The browser will use this to constrain the lifecycle of worker
// processes (SharedWorkers are shut down when their last associated document

Powered by Google App Engine
This is Rietveld 408576698