Chromium Code Reviews| Index: content/renderer/media/media_recorder_handler.h |
| diff --git a/content/renderer/media/media_recorder_handler.h b/content/renderer/media/media_recorder_handler.h |
| index e4f0597b45b90e0d8da043282517b35e129e4e79..4962294878d052ce3980909f351b268c1ceb9278 100644 |
| --- a/content/renderer/media/media_recorder_handler.h |
| +++ b/content/renderer/media/media_recorder_handler.h |
| @@ -10,6 +10,7 @@ |
| #include "base/strings/string_piece.h" |
| #include "base/threading/thread_checker.h" |
| #include "content/common/content_export.h" |
| +#include "third_party/WebKit/public/platform/WebMediaRecorderHandler.h" |
| #include "third_party/WebKit/public/platform/WebMediaRecorderHandlerClient.h" |
| #include "third_party/WebKit/public/platform/WebMediaStream.h" |
| @@ -35,21 +36,22 @@ class VideoTrackRecorder; |
| // All methods are called on the same thread as construction and destruction, |
| // i.e. the Main Render thread. |
| // TODO(mcasas): Implement audio recording. |
| -class CONTENT_EXPORT MediaRecorderHandler final { |
| +class CONTENT_EXPORT MediaRecorderHandler final |
| + : public blink::WebMediaRecorderHandler { |
| public: |
| MediaRecorderHandler(); |
| ~MediaRecorderHandler(); |
|
miu
2015/09/10 02:31:47
Please add override keyword for the dtor too.
|
| // See above, these methods should override blink::WebMediaRecorderHandler. |
| - bool canSupportMimeType(const blink::WebString& mimeType); |
| + bool canSupportMimeType(const blink::WebString& mimeType) override; |
| bool initialize(blink::WebMediaRecorderHandlerClient* client, |
| const blink::WebMediaStream& media_stream, |
| - const blink::WebString& mimeType); |
| - bool start(); |
| - bool start(int timeslice); |
| - void stop(); |
| - void pause(); |
| - void resume(); |
| + const blink::WebString& mimeType) override; |
| + bool start() override; |
| + bool start(int timeslice) override; |
| + void stop() override; |
| + void pause() override; |
| + void resume() override; |
| private: |
| friend class MediaRecorderHandlerTest; |