Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3086)

Unified Diff: content/renderer/media/media_recorder_handler.h

Issue 1330873002: MediaRecorderHandler: connecting Blink factory method to content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/media_recorder_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_recorder_handler.h
diff --git a/content/renderer/media/media_recorder_handler.h b/content/renderer/media/media_recorder_handler.h
index e4f0597b45b90e0d8da043282517b35e129e4e79..4962294878d052ce3980909f351b268c1ceb9278 100644
--- a/content/renderer/media/media_recorder_handler.h
+++ b/content/renderer/media/media_recorder_handler.h
@@ -10,6 +10,7 @@
#include "base/strings/string_piece.h"
#include "base/threading/thread_checker.h"
#include "content/common/content_export.h"
+#include "third_party/WebKit/public/platform/WebMediaRecorderHandler.h"
#include "third_party/WebKit/public/platform/WebMediaRecorderHandlerClient.h"
#include "third_party/WebKit/public/platform/WebMediaStream.h"
@@ -35,21 +36,22 @@ class VideoTrackRecorder;
// All methods are called on the same thread as construction and destruction,
// i.e. the Main Render thread.
// TODO(mcasas): Implement audio recording.
-class CONTENT_EXPORT MediaRecorderHandler final {
+class CONTENT_EXPORT MediaRecorderHandler final
+ : public blink::WebMediaRecorderHandler {
public:
MediaRecorderHandler();
~MediaRecorderHandler();
miu 2015/09/10 02:31:47 Please add override keyword for the dtor too.
// See above, these methods should override blink::WebMediaRecorderHandler.
- bool canSupportMimeType(const blink::WebString& mimeType);
+ bool canSupportMimeType(const blink::WebString& mimeType) override;
bool initialize(blink::WebMediaRecorderHandlerClient* client,
const blink::WebMediaStream& media_stream,
- const blink::WebString& mimeType);
- bool start();
- bool start(int timeslice);
- void stop();
- void pause();
- void resume();
+ const blink::WebString& mimeType) override;
+ bool start() override;
+ bool start(int timeslice) override;
+ void stop() override;
+ void pause() override;
+ void resume() override;
private:
friend class MediaRecorderHandlerTest;
« no previous file with comments | « no previous file | content/renderer/media/media_recorder_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698