Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 133083002: Update .gitignore to ignore nodejs binaries. (Closed)

Created:
6 years, 11 months ago by raymes
Modified:
6 years, 11 months ago
Reviewers:
Sam McNally, hinoka
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Update .gitignore to ignore nodejs binaries. R=sammc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
6 years, 11 months ago (2014-01-10 01:58:45 UTC) #1
raymes
6 years, 11 months ago (2014-01-10 02:19:48 UTC) #2
Sam McNally
lgtm
6 years, 11 months ago (2014-01-10 02:22:49 UTC) #3
raymes
Committed patchset #1 manually as r244047 (presubmit successful).
6 years, 11 months ago (2014-01-10 02:25:04 UTC) #4
raymes
6 years, 11 months ago (2014-01-14 03:33:07 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/137793002/ by raymes@chromium.org.

The reason for reverting is: nodejs binaries were removed in 
https://codereview.chromium.org/133033003.

Powered by Google App Engine
This is Rietveld 408576698