[Android] Persist ordering of NTP suggestions.

chrome/browser/android/most_visited_sites.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
 #define CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
 
 #include <jni.h>
 
 #include <string>
 #include <vector>
 
 #include "base/android/scoped_java_ref.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/scoped_observer.h"
-#include "chrome/browser/profiles/profile.h"
 #include "components/history/core/browser/history_types.h"
 #include "components/history/core/browser/top_sites_observer.h"
 #include "components/suggestions/proto/suggestions.pb.h"
 #include "components/sync_driver/sync_service_observer.h"
 
 namespace suggestions {
 class SuggestionsService;
 }
 
+namespace user_prefs {
+class PrefRegistrySyncable;
+}
+
 class GURL;
 class PopularSites;
+class Profile;
 
 // Provides the list of most visited sites and their thumbnails to Java.
 class MostVisitedSites : public sync_driver::SyncServiceObserver,
                          public history::TopSitesObserver {
  public:
   explicit MostVisitedSites(Profile* profile);
   void Destroy(JNIEnv* env, jobject obj);
   void OnLoadingComplete(JNIEnv* env, jobject obj);
   void SetMostVisitedURLsObserver(JNIEnv* env,
                                   jobject obj,
                                   jobject j_observer,
                                   jint num_sites);
   void GetURLThumbnail(JNIEnv* env,
                        jobject obj,
                        jstring url,
                        jobject j_callback);
 
   void BlacklistUrl(JNIEnv* env, jobject obj, jstring j_url);
   void RecordOpenedMostVisitedItem(JNIEnv* env, jobject obj, jint index);
 
   // sync_driver::SyncServiceObserver implementation.
   void OnStateChanged() override;
 
   // Registers JNI methods.
   static bool Register(JNIEnv* env);
 
+  static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+
+  // The source of the Most Visited sites.
+  enum MostVisitedSource { TOP_SITES, SUGGESTIONS_SERVICE, POPULAR };
+
+  struct Suggestion {

[Bernhard Bauer, 2015/09/08 15:44:25]

Can you make this private and only forward-declare in here in the header?

[knn, 2015/09/09 09:35:38]

Made private but can't forward declare as it is used in tests.

+    base::string16 title;
+    std::string url;
+    std::string host;
+    MostVisitedSource source;
+    // Only for source == SUGGESTIONS_SERVICE

[Bernhard Bauer, 2015/09/08 15:44:25]

Document that it's -1 otherwise? (Or at least that it's only guaranteed to be a
valid index if source == SUGGESTIONS_SERVICE)

[knn, 2015/09/09 09:35:38]

Done.

+    int provider_index;
+
+    Suggestion(const base::string16& title,
+               const std::string& url,
+               MostVisitedSource source);
+    Suggestion(const base::string16& title,
+               const std::string& url,
+               const std::string& host,
+               MostVisitedSource source);
+    Suggestion(const base::string16& title,
+               const std::string& url,
+               MostVisitedSource source,
+               int provider_index);

[Bernhard Bauer, 2015/09/08 15:44:25]

Add a destructor?

[knn, 2015/09/09 09:35:38]

Done. Just curious, whether this serves any purpose other than document that I
haven't forgotten?

[Marc Treib, 2015/09/09 09:58:42]

Some trybots check that "non-trivial" structs have a destructor. I ran into that
recently, see https://codereview.chromium.org/1314493013/#ps120001

+    std::string GetSourceHistogramName() const;

[Bernhard Bauer, 2015/09/08 15:44:25]

Add DISALLOW_COPY_AND_ASSIGN if you are not using those methods. If you are, add
a comment that copying and assignment are allowed.

[knn, 2015/09/09 09:35:38]

Done.

+  };
+
  private:
   friend class MostVisitedSitesTest;
 
-  // The source of the Most Visited sites.
-  enum MostVisitedSource {
-    TOP_SITES,
-    SUGGESTIONS_SERVICE
-  };
-
   ~MostVisitedSites() override;
   void QueryMostVisitedURLs();
 
   // Initialize the query to Top Sites. Called if the SuggestionsService is not
   // enabled, or if it returns no data.
   void InitiateTopSitesQuery();
 
   // Callback for when data is available from TopSites.
   void OnMostVisitedURLsAvailable(
       const history::MostVisitedURLList& visited_list);
 
   // Callback for when data is available from the SuggestionsService.
   void OnSuggestionsProfileAvailable(
       const suggestions::SuggestionsProfile& suggestions_profile);
 
-  // Adds the suggestions from |popular_sites_| into |titles| and |urls|. This
-  // might reorder |titles| and |urls| to retain the absolute positions of the
-  // popular suggestions. Also updates |tile_sources_| accordingly.
-  void AddPopularSites(std::vector<base::string16>* titles,
-                       std::vector<std::string>* urls);
+  // Takes the personal suggestions and adds popular suggestions if necessary
+  // and reorders the suggestions based on the previously displayed order.
+  void AddPopularSites(ScopedVector<Suggestion>* suggestions);
 
   // Workhorse for AddPopularSites above. Implemented as a separate static
   // method for ease of testing.
-  static void AddPopularSitesImpl(
-      int num_sites,
-      const std::vector<base::string16>& popular_titles,
-      const std::vector<std::string>& popular_urls,
-      std::vector<base::string16>* titles,
-      std::vector<std::string>* urls,
-      std::vector<std::string>* tile_sources);
+  static ScopedVector<Suggestion> MergeSuggestions(
+      ScopedVector<Suggestion>* personal_suggestions,
+      ScopedVector<Suggestion>* popular_suggestions,
+      const std::vector<std::string>& old_sites_url,
+      const std::vector<bool>& old_sites_is_personal);
 
   // Notify the Java side observer about the availability of Most Visited Urls.
-  void NotifyMostVisitedURLsObserver(const std::vector<base::string16>& titles,
-                                     const std::vector<std::string>& urls);
+  void NotifyMostVisitedURLsObserver();
 
   void OnPopularSitesAvailable(bool success);
 
   // Runs on the UI Thread.
   void OnLocalThumbnailFetched(
       const GURL& url,
       scoped_ptr<base::android::ScopedJavaGlobalRef<jobject>> j_callback,
       scoped_ptr<SkBitmap> bitmap);
 
   // Callback for when the thumbnail lookup is complete.
@@ skipping 39 matching lines @@
   // Counters for UMA metrics.
 
   // Number of tiles using a local thumbnail image for this NTP session.
   int num_local_thumbs_;
   // Number of tiles for which a server thumbnail is provided.
   int num_server_thumbs_;
   // Number of tiles for which no thumbnail is found/specified.
   // In this case a gray tile is used as the main tile.
   int num_empty_thumbs_;
 
-  // Identifier for where each tile came from (client, server, popular). Used
-  // for logging.
-  std::vector<std::string> tile_sources_;
-
   ScopedObserver<history::TopSites, history::TopSitesObserver> scoped_observer_;
 
   MostVisitedSource mv_source_;
 
   scoped_ptr<PopularSites> popular_sites_;
 
+  ScopedVector<Suggestion> current_suggestions_;
+
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_