Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1330763002: Revert of Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator (Closed)

Created:
5 years, 3 months ago by keishi
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData (patchset #4 id:60001 of https://codereview.chromium.org/1225233005/ ) Reason for revert: blink_perf.css regression https://code.google.com/p/chromium/issues/detail?id=513378#makechanges Original issue's description: > Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData > > BUG=509911 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199288 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199294 TBR=haraken@chromium.org,yutak@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=509911 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/core/css/invalidation/StyleInvalidator.h View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
keishi
Created Revert of Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData
5 years, 3 months ago (2015-09-07 09:33:26 UTC) #1
haraken
LGTM Does this really affect performance?
5 years, 3 months ago (2015-09-07 09:35:08 UTC) #2
keishi
On 2015/09/07 09:35:08, haraken wrote: > LGTM > > Does this really affect performance? I ...
5 years, 3 months ago (2015-09-07 09:36:55 UTC) #3
haraken
5 years, 3 months ago (2015-09-07 09:44:04 UTC) #4
Message was sent while issue was closed.
On 2015/09/07 09:36:55, keishi wrote:
> On 2015/09/07 09:35:08, haraken wrote:
> > LGTM
> > 
> > Does this really affect performance?
> 
> I doubt it but if the bisect points to this so I thought I'd revert it and
see.

Makes sense.

Powered by Google App Engine
This is Rietveld 408576698