Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 133073014: Dispatch chrome.app.runtime.onRestarted to ephemeral apps (Closed)

Created:
6 years, 10 months ago by tmdiep
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Dispatch chrome.app.runtime.onRestarted to ephemeral apps If Chrome is restarted while an ephemeral app is running, the app will be dispatched the onRestarted() event on restart. If the app does not listen to this event, it is just relaunched. BUG=339001 TEST=To test dispatch of the onRestarted event: Find the "Restarted Event Sample" app in the Web Store and run it ephemerally. Restart Chrome, e.g. using chrome://restart, and verify that the app is restarted. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tmdiep
koz: PTAL, thanks. This patch is related to: https://codereview.chromium.org/118033002/ We decided to let the onRestarted() ...
6 years, 10 months ago (2014-01-30 07:11:31 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 10 months ago (2014-01-31 02:41:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/133073014/1
6 years, 10 months ago (2014-01-31 05:33:48 UTC) #3
commit-bot: I haz the power
Change committed as 248145
6 years, 10 months ago (2014-01-31 07:09:18 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 07:09:22 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698