content/browser/android/web_contents_observer_android.h - Issue 133073012: android: Fix ContentViewCore and RenderWidgetHostViewAndroid lifetime issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_android.h

Issue 133073012: android: Fix ContentViewCore and RenderWidgetHostViewAndroid lifetime issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_android.h

diff --git a/content/browser/android/web_contents_observer_android.h b/content/browser/android/web_contents_observer_android.h

index 15a136390f84a54a68da3123777fa0b7675b1945..0436e8ed7c3326b041ad76e4b79a946862be40e7 100644

--- a/content/browser/android/web_contents_observer_android.h

+++ b/content/browser/android/web_contents_observer_android.h

@@ -17,6 +17,7 @@

namespace content {

+class ContentViewCore;

class RenderViewHost;

class WebContents;

@@ -26,6 +27,7 @@ class WebContentsObserverAndroid : public WebContentsObserver {

public:

WebContentsObserverAndroid(JNIEnv* env,

jobject obj,

+ ContentViewCore* content_view_core,

WebContents* web_contents);

virtual ~WebContentsObserverAndroid();

@@ -86,6 +88,7 @@ class WebContentsObserverAndroid : public WebContentsObserver {

const base::string16& description,

const GURL& url);

+ ContentViewCore* content_view_core_;

JavaObjectWeakGlobalRef weak_java_observer_;

DISALLOW_COPY_AND_ASSIGN(WebContentsObserverAndroid);