Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 133073010: [Views] Cause the window controls to be reset independent of title update in the non-client view. (Closed)

Created:
6 years, 11 months ago by Greg Billock
Modified:
6 years, 11 months ago
Reviewers:
danakj, sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

[Views] Cause the window controls to be reset independent of title update in the non-client view. The reason for this is that if the title doesn't change, then the window frame controls aren't ever set on Init. For the bubble, this means the close control is never set to its correct state. R=danakj@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246185

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M ui/views/widget/widget.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Greg Billock
6 years, 11 months ago (2014-01-17 22:35:00 UTC) #1
sky
https://codereview.chromium.org/133073010/diff/1/ui/views/widget/widget.cc File ui/views/widget/widget.cc (right): https://codereview.chromium.org/133073010/diff/1/ui/views/widget/widget.cc#newcode384 ui/views/widget/widget.cc:384: non_client_view_->ResetWindowControls(); This is easy to break. How about a ...
6 years, 11 months ago (2014-01-18 22:16:33 UTC) #2
Greg Billock
https://codereview.chromium.org/133073010/diff/1/ui/views/widget/widget.cc File ui/views/widget/widget.cc (right): https://codereview.chromium.org/133073010/diff/1/ui/views/widget/widget.cc#newcode384 ui/views/widget/widget.cc:384: non_client_view_->ResetWindowControls(); On 2014/01/18 22:16:33, sky wrote: > This is ...
6 years, 11 months ago (2014-01-21 19:54:32 UTC) #3
sky
LGTM
6 years, 11 months ago (2014-01-21 20:43:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/133073010/60001
6 years, 11 months ago (2014-01-21 22:29:37 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 00:30:48 UTC) #6
Message was sent while issue was closed.
Change committed as 246185

Powered by Google App Engine
This is Rietveld 408576698