Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 133073007: CSP: 'sandbox' should be ignored in report-only mode. (Closed)

Created:
6 years, 11 months ago by Mike West
Modified:
6 years, 11 months ago
CC:
blink-reviews, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

CSP: 'sandbox' should be ignored in report-only mode. This is the behavior Firefox is running with[1], and has recently been explicitly clarified in the spec[2]. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=671389 [2]: https://github.com/w3c/webappsec/commit/2cc237a696e982be59886c8f2ba0ed2d84f22c81 BUG=335489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
LayoutTests/http/tests/security/contentSecurityPolicy/resources/sandbox.php View 1 chunk +5 lines, -1 line 0 comments Download
LayoutTests/http/tests/security/contentSecurityPolicy/sandbox-report-only.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/http/tests/security/contentSecurityPolicy/sandbox-report-only-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
Source/core/frame/ContentSecurityPolicy.h View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/frame/ContentSecurityPolicy.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Jochen, Adam, mind taking a look? -mike
6 years, 11 months ago (2014-01-17 09:47:52 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-17 16:35:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/133073007/1
6 years, 11 months ago (2014-01-17 16:35:21 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 17:56:07 UTC) #4
Message was sent while issue was closed.
Change committed as 165322

Powered by Google App Engine
This is Rietveld 408576698