Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1330713003: Add a GN import for sanitizers.gni. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a GN import for sanitizers.gni. The is_*san flags are moving from the master build config file into this .gni file. This patch will allow V8 to continue compiling when that change is landed. Committed: https://crrev.com/0014ad92a3fa308402140016a2b50be6d169779e Cr-Commit-Position: refs/heads/master@{#30623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 3 months ago (2015-09-04 21:33:33 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-07 14:24:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330713003/1
5 years, 3 months ago (2015-09-07 14:24:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 15:22:49 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 15:23:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0014ad92a3fa308402140016a2b50be6d169779e
Cr-Commit-Position: refs/heads/master@{#30623}

Powered by Google App Engine
This is Rietveld 408576698