Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330653003: Oilpan: tidy up NavigationScheduler. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, kinuko+watch, Nate Chapin, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: tidy up NavigationScheduler. Allocate this object separately and not as a part of a LocalFrame. The main motivation for this is to play better with its use of a CancellableTaskFactory following r201780. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201794

Patch Set 1 #

Patch Set 2 : add missing include #

Total comments: 2

Patch Set 3 : remove redundant constructor hiding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -51 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/NavigationScheduler.h View 1 2 4 chunks +38 lines, -37 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-04 09:42:25 UTC) #2
haraken
LGTM https://codereview.chromium.org/1330653003/diff/20001/Source/core/loader/NavigationScheduler.h File Source/core/loader/NavigationScheduler.h (right): https://codereview.chromium.org/1330653003/diff/20001/Source/core/loader/NavigationScheduler.h#newcode126 Source/core/loader/NavigationScheduler.h:126: FrameNavigationDisabler() = delete; This won't be needed (it's ...
5 years, 3 months ago (2015-09-04 12:04:21 UTC) #4
sof
https://codereview.chromium.org/1330653003/diff/20001/Source/core/loader/NavigationScheduler.h File Source/core/loader/NavigationScheduler.h (right): https://codereview.chromium.org/1330653003/diff/20001/Source/core/loader/NavigationScheduler.h#newcode126 Source/core/loader/NavigationScheduler.h:126: FrameNavigationDisabler() = delete; On 2015/09/04 12:04:21, haraken wrote: > ...
5 years, 3 months ago (2015-09-04 12:10:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1330653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1330653003/40001
5 years, 3 months ago (2015-09-04 12:10:46 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 13:22:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201794

Powered by Google App Engine
This is Rietveld 408576698