LayoutTests/fast/dom/intersection-observer.html - Issue 1330633003: Intersection Observer first draft

Side by Side Diff: LayoutTests/fast/dom/intersection-observer.html

Issue 1330633003: Intersection Observer first draft Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix segfault on null input. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3

	4 <body>
	ojan 2015/09/21 03:49:08 Nit: No need for the body element Nit: No need for the body element MikeB 2015/09/24 19:04:03 Done. Show quoted text On 2015/09/21 03:49:08, ojan wrote: > Nit: No need for the body element Done.
	5

	6 <div id="top_div" style="background-color:blue;position:absolute; top:50px; left :20px; width:600px; height:800px">

	7 </div>

	8

	9 <div id="target_div" style="background-color:red;position:absolute; top:855px; left:66px; width:300px; height:250px">
	ojan 2015/09/21 03:49:08 Please add test cases for the following or add app Please add test cases for the following or add appropriate TODOs. I'm not sure, but I think this patch doesn't get these right. 1. Removing an element from the DOM removes its observation. 2. Clipping across frame boundaries works (you can use <iframe srcdoc> to make these tests a bit easier to write) 3. Clipping from overflow:hidden/scroll/auto ancestors works. 4. Observing an element that's not appended to the DOM (should throw). I think the patch gets the following right, but we should have test coverage for it anyways: 1. Create an element, append it to the DOM, register an observer. Make sure that the first callback you get has the right rects. 2. Calling observe leaving out the second argument should work.
	10 </div>

	11

	12 </body>

	13

	14

	15

	16 <script>

	17 window.jsTestIsAsync = true;

	18

	19 var entries = [];

	20 var expectedEntries = [

	21 {

	22 time:'mark',

	23 quads:[{top:855, right:366, bottom: 1000, left: 66}],

	24 viewport: {top:400, right:785, bottom:1000, left:0},

	25 target: document.getElementById('target_div')

	26 }

	27 ];

	28

	29 var a = {}, b = {};

	30 function shouldBeClientRect(name, value1, value2)

	31 {

	32 a[name] = value1;

	33 b[name] = value2;

	34 shouldBe('a.'+name+'.top', 'b.'+name+'.top');

	35 shouldBe('a.'+name+'.right', 'b.'+name+'.right');

	36 shouldBe('a.'+name+'.bottom', 'b.'+name+'.bottom');

	37 shouldBe('a.'+name+'.left', 'b.'+name+'.left');

	38 }

	39

	40 function testIntersectionObserver()

	41 {

	42 var observer = new IntersectionObserver(intersectionCallback);

	43

	44 function intersectionCallback(changes)

	45 {

	46 entries = entries.concat(changes);

	47 if (entries.length != expectedEntries.length)

	48 return;

	49 shouldBe('entries[0].time', '0');

	50 shouldBeClientRect('quads_0', changes[0].quads[0], expectedEntries[0].qu ads[0]);

	51 shouldBeClientRect('viewport', changes[0].viewport, expectedEntries[0].v iewport);

	52 shouldBe('entries[0].target', 'expectedEntries[0].target');

	53 testRunner.notifyDone();

	54 }

	55

	56 var config = { entryTypes: ['mark', 'measure'] };
	ojan 2015/09/21 03:49:08 I think this is probably leftover from the test ca I think this is probably leftover from the test case you ported this from? Which brings up a question actually, should passing in a dict with invalid fields throw? I think the answer is no, but I'm not sure. MikeB 2015/09/24 19:04:03 Done. Show quoted text On 2015/09/21 03:49:08, ojan wrote: > I think this is probably leftover from the test case you ported this from? > > Which brings up a question actually, should passing in a dict with invalid > fields throw? I think the answer is no, but I'm not sure. Done.
	57 var target_div = document.getElementById('target_div');

	58 observer.observe(target_div, config);

	59 window.setTimeout(function() { window.scrollBy(0, 400); }, 0);
	ojan 2015/09/21 03:49:09 Do you need the setTimeout? I think you should be Do you need the setTimeout? I think you should be able to just force a layout and then sync call scrollBy: document.documentElement.offsetTop; window.scrollBy(0, 400);
	60 }

	61

	62 description("This tests that IntersectionObserver gets called the right number o f times.");

	63

	64 testIntersectionObserver();

	65 testRunner.waitUntilDone();

	66 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/intersection-observer-expected.txt » ('j') | Source/bindings/core/v8/V8IntersectionObserverCallback.h » ('J')